[#35184] - [5.3] Modification fields header tag, module tag add custom options in XML
- Pending
- Medium
- Build: 4.0-dev
- # 35184
- Diff
- korenevskiy:Modification-fields-HeaderTag,-ModuleTag---Addcustom-options
User tests: Successful: Unsuccessful:
I periodically encounter the problem of adding my own unique tags for the module.
But now you can add tags in the new module: LI , and others. For cases of non-standard situations.
<fieldset>
<legend>Title</legend>
Module content
</fieldset>
Example testing
<field
name="header_tag"
type="headertag"
label="COM_MODULES_FIELD_HEADER_TAG_LABEL"
default="h5" >
<option value="figcaption"><figcaption></option>
<option value="legend"><legend></option>
<option value="label"><label></option>
<option value="summary"><summary></option>
</field>
<field
name="module_tag"
type="moduletag"
label="COM_MODULES_FIELD_MODULE_TAG_LABEL"
default="div" >
<option value="figure"><figure></option>
<option value="fieldset"><fieldset></option>
<option value="li"><li></option>
<option value="details"><details></option>
</field>
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
checking the tests showed an error. I don't understand the reason for the error. What could be the error?
@korenevskiy Tests are currently failing for all PRs ti the 4.0-dev branch. It's a known issue and will be fixed soon, but maybe not tonight. For the meantime just be patient and ignore it.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
@korenevskiy could you please provide testing instructions for this PR?
Please provide an example how this makes sense.
@korenevskiy could you please provide testing instructions for this PR?
@rdeutz @drmenzelit
Sorry.
<field
name="header_tag"
type="headertag"
label="COM_MODULES_FIELD_HEADER_TAG_LABEL"
default="h5" >
<option value="figcaption"><figcaption></option>
<option value="legend"><legend></option>
<option value="label"><label></option>
<option value="summary"><summary></option>
</field>
<field
name="module_tag"
type="moduletag"
label="COM_MODULES_FIELD_MODULE_TAG_LABEL"
default="div" >
<option value="figure"><figure></option>
<option value="fieldset"><fieldset></option>
<option value="li"><li></option>
<option value="details"><details></option>
</field>
| Labels |
Removed:
?
|
||
| Labels |
Added:
Conflicting Files
|
||
This pull request has been automatically rebased to 4.3-dev.
obuisard
- | Title |
|
||||||
| Labels |
Added:
Feature
PR-5.0-dev
?
Removed: Conflicting Files ? |
||
I have tested this item ✅ successfully on 5518ac3
Works as described. Can't see the issue with giving people the choice to do custom things.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35184.
| Title |
|
||||||
I have tested this item ? unsuccessfully on 5518ac3
@wilsonge I think he wants to use the PR to add options, but this does not work with the PR as desired.
My test failed because the advances.xml overwrites the settings from the config of the module
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35184.
@nielsnuebel
Thanks for the support. Where did you find this file? There is no such file in joomla. Perhaps a third-party extension makes a similar correction, which is what this PR does. Can you give me the address of this file in more detail
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
checking the tests showed an error. I don't understand the reason for the error. What could be the error?