? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 Aug 2021

Summary of Changes

Add missing mssql updates for #__template_styles

Testing Instructions

code review or testing mssql

@richard67 nothing urgent but please take a look that we didnt broken the mssql syntax here.

Actual result BEFORE applying this Pull Request

The structure is not 1:1 with mysql and postgressql

Expected result AFTER applying this Pull Request

the structure is 1:1 while it does not have an impact as the colums are not used nor are you allowed to upgrade from 3.10 to 4 using mssql

Documentation Changes Required

none.

avatar zero-24 zero-24 - open - 17 Aug 2021
avatar zero-24 zero-24 - change - 17 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2021
Category MS SQL SQL Administration com_admin Installation
avatar zero-24 zero-24 - change - 19 Aug 2021
Labels Added: ?
avatar richard67
richard67 - comment - 21 Aug 2021

@zero-24 I've allowed myself to commit my suggested change.

avatar richard67 richard67 - test_item - 21 Aug 2021 - Tested successfully
avatar richard67
richard67 - comment - 21 Aug 2021

I have tested this item successfully on 0db47e9

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35163.

avatar richard67
richard67 - comment - 21 Aug 2021

The reason why this PR is needed is that people using MS SQL Server might have to migrate their database to a supported one when being on 3.10, if they haven't done this before, and then the columns might be missing or the migration might fail.

avatar alikon alikon - test_item - 21 Aug 2021 - Tested successfully
avatar alikon
alikon - comment - 21 Aug 2021

I have tested this item successfully on 0db47e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35163.

avatar alikon alikon - change - 21 Aug 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35163.

avatar zero-24 zero-24 - close - 22 Aug 2021
avatar zero-24 zero-24 - merge - 22 Aug 2021
avatar zero-24 zero-24 - change - 22 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-22 10:47:42
Closed_By zero-24
Labels Added: ?
avatar zero-24
zero-24 - comment - 22 Aug 2021

Great thanks guys :)

Add a Comment

Login with GitHub to post a comment