Feeling Lucky
PBF
?
[#35157] - [4] Remove FeedDocument Generator comment
- Closed
- 6 Mar 2022
- Medium
- Build: 4.0-dev
- # 35157
- Diff
- PhilETaylor:patch-225
User tests: Successful: Unsuccessful:
Summary of Changes
Both the RSS and ATOM feed output a generator tag correctly in their XML as well as a vanity xml comment that doesnt provide anything more than is already in the XML specification and can/should be removed.
Testing Instructions
Load the RSS and ATOM feeds of your site - look at the XML
Actual result BEFORE applying this Pull Request
ATOM
<?xml version="1.0" encoding="utf-8"?>
<!-- generator="Joomla! - Open Source Content Management" -->
<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-gb">
<title type="text">Home</title>
<subtitle type="text"></subtitle>
<link rel="alternate" type="text/html" href="http://127.0.0.1:4444">
<id>http://127.0.0.1:4444/index.php</id>
<updated>2021-08-16T21:46:11+00:00</updated>
<generator uri="https://www.joomla.org">Joomla! - Open Source Content Management</generator>
<link rel="self" type="application/atom+xml" href="http://127.0.0.1:4444/index.php?format=feed&type=atom">RSS
<?xml version="1.0" encoding="utf-8"?>
<!-- generator="Joomla! - Open Source Content Management" -->
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
<channel>
<title>Home</title>
<description><![CDATA[]]></description>
<link>http://127.0.0.1:4444/index.php</link>
<lastBuildDate>Mon, 16 Aug 2021 21:43:49 +0000</lastBuildDate>
<generator>Joomla! - Open Source Content Management</generator>
<atom:link rel="self" type="application/rss+xml" href="http://127.0.0.1:4444/index.php?format=feed&type=rss"/>
<language>en-gb</language>Expected result AFTER applying this Pull Request
<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-gb"><?xml version="1.0" encoding="utf-8"?>
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Quy
- comment
- 23 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35157.
| Labels |
Added:
?
?
|
||
| Labels |
Added:
PBF
?
Removed: ? ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-06 21:12:45 |
| Closed_By | ⇒ | PhilETaylor |
I agree that it can be removed but I am intrigued why it should be removed