User tests: Successful: Unsuccessful:
Only throw error if file does not exist.
If folder in zip file is empty then extract does not create the folder.
This caused the library installation to fail.
Install library
lib_bftest1.zip
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
If I remember correctly we have faced the same issue with core and that is why folders that would otherwise be empty eg cache, tmp and logs all have an index.html in there to ensure that the folder is created. I would recommend that you do the same with your library instead of this PR which as @bembelimen points out can introduce other issues.
Labels |
Added:
?
|
Labels |
Added:
?
Removed: ? |
Empty folders in a zip file are bad. Windows even even removes them when you create zips. My 2c is that we dont need a solution in core for this and developers just have to include an index.html or similar in the folder if they want to include it in the zip
Thinking about this, there still shouldn't be empty folder ignored when it's there. So I'm closing this for now.
Still thanks for your contribution.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-22 11:40:19 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
?
Removed: ? |
Hello @BrainforgeUK thank you for your PR.
I'm a bit unsure if this is a good way to be honest, if e.g. the unzip process has an error and there is then an empty folder which should have files but there aren't any, the installation succeed instead of fail...