[#35148] - [3.10] [4.0] Fix wrong number of parameters for sprintf
- Fixed in Code Base
- 21 Aug 2021
- Medium
- Build: 3.10-dev
- # 35148
- Diff
- richard67:3.10-dev-fix-sprintf-wrong-number-of-params
User tests: Successful: Unsuccessful:
Pull Request for Issue #35122 .
Summary of Changes
This pull request (PR) fixes the wrong number of parameters in the 1st and the 3rd call to sprintf reported with issue #35122 .
The 2nd call reported in the issue is J4 only and has been already fixed with this commit in the 4.0-dev branch: 76875db
In addition this PR fixes the same mistake for the call to \JText::sprintf just above the 1st reported issue. The language sting JLIB_MAIL_INVALID_EMAIL_SENDER uses nearly the same text with the same two %s as the reported issue in both 3.10-dev and 4.0-dev.
I decided not to fix that language string JLIB_MAIL_INVALID_EMAIL_SENDER in order not to cause translation works.
Not sure if this PR fixes these issues in the best way, but it should work.
All fixes in this PR here need to be merged up into 4.0-dev after having been merged into 3.10-dev.
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Wrong number of parameters in calls to sprintf and \JText::sprintf.
Expected result AFTER applying this Pull Request
Right number of parameters in calls to sprintf and \JText::sprintf.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Title |
|
||||||
@ricardo1709 Unfortunately approval is nice but doesn't count like a test. Could you mark it in the issue tracker, too? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35148.
@ricardo1709 Thanks.
| Category | Libraries | ⇒ | Administration Language & Strings Libraries |
@ricardo1709 Could you test again? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35148.
zero-24
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-21 12:22:00 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
Language Change
|
||
@ricardo1709 Done. Ready for tests/reviews.