[#35142] - [4.0] Subform styling for non table layout
- Fixed in Code Base
- 25 Aug 2021
- Medium
- Build: 4.0-dev
- # 35142
- Diff
- Fedik:subform-styling
User tests: Successful: Unsuccessful:
Summary of Changes
Fixing subform styling.
Adopted from joomla 3
Testing Instructions
Apply patch, run node build/build.js --compile-css
Add subform field somewhere, example in mod_custom xml
<field type="subform" name="subform" label="subform" multiple="true">
<form>
<field type="text" name="text" label="text" />
<field type="textarea" name="textarea" label="textarea" />
</form>
</field>Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change Layout |
| Labels |
Added:
?
NPM Resource Changed
|
||
| Labels |
Added:
?
Removed: ? |
||
| Title |
|
||||||
| Title |
|
||||||
Hello Fedik,
I tested your changes successfully on my machine.
Although I noticed that dragging and dropping feels a bit clunky.
You have to be very precise with the mouse to grab an item.
Maybe that is tweakable?
Also while holding on to an item it becomes hard to see what you´re currently holding.
That may be because white on white is hard to see.
Nonetheless good addition :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.
| Labels |
Added:
?
Removed: ? |
||
Also while holding on to an item it becomes hard to see what you´re currently holding.
I have added a light background for "draggable" section,
Please test again.
Can you use the same styling for the dragging as is used when you are ordering a menu item etc. That will make the ui more consistent
Can you use the same styling for the dragging as is used when you are ordering a menu item etc. That will make the ui more consistent
yes, if someone tell me where I can copy that ;)
It's coming from dragula in media/vendor
ah, wait, that toxic green? no, not allowed :)
okay, changed, however I not like that color.
just for consistency
I have tested this item
Thanks, nice UI improvement
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.
I have tested this item
This layout is a lot more clear.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35142.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-25 15:28:48 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
Removed: ? |
||
Thanks!
this for 4.0.x