User tests: Successful: Unsuccessful:
plgContentLoadmodule::_loadmod() caches content it creates using just the module type as the index. If more than one module of the same type is included using {loadmodule}, whichever module renders first provides the content for all instances of that module type.
The fix uses a concatenation of the module type and title, providing a unique index.
I tried to recreate the issue from http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33663&start=0 without applying the patch and I don't see any problem with it. I can not recreate the issue.
[Copy of tracker item]
test with Joomla 2.5.25-dev
I could not reproduce the issue. Here are additional test instructions, I may have missed the point:
Content of my article:
ID 33663
First module id=87
{loadposition position-9}
Second module id=88
{loadposition position-10}
Did another test with positions not used in the template, with this article content:
ID 33663
First module id=87
{loadposition feed1}
Second module id=88
{loadposition feed2}
The two module content are displayed, and are different.
Please provide more instructions.
moving to "Information Required"
Labels |
Removed:
?
|
Thank you for your contribution and participation in the bug tracking process. As there has been no response to the request for further information I am closing this report at this time.
We have now moved our bug tracking process to http://issues.joomla.org/ so if you have further information that would enable this issue to be reopened please update the issue at http://issues.joomla.org/tracker/joomla-cms/3512 and it can be reopened.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-22 10:39:06 |
My apologies, been busy. rvbgnu's example used {loadposition}, not {loadmodule}. The issue is specific {loadmodule}
Status | Closed | ⇒ | New |
Thanks for the precision @routinet. No need to apologise, that's me who read bad sometimes...
So I could reproduce the problem with two same type Custom HTML modules mod1 and mod2. Article content:
Testing issue #3512
{loadmodule mod_custom, mod1}
{loadmodule mod_custom, mod2}
```<br /><br />*This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="http://issues.joomla.org/">http://issues.joomla.org/</a>.*
@test
Work as expected! Thanks @routinet!
Please need a second test
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
I'm not sure why the end braces are showing up on the same line - my edit did not include that change. How can I alter the PR?
How can I alter the PR?
If you're working with the GitHub UI, just navigate to the file in your own branch and edit it again. The PR will update. In that case it would be the following file:
https://github.com/routinet/joomla-cms/blob/2.5.x/plugins/content/loadmodule/loadmodule.php
Title |
|
Adjusted PR title to be more clear.
Good to go
Status | New | ⇒ | Ready to Commit |
thanks @routinet
Can we have a RTC label on github? (JIssues status is now RTC) :D
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Status | Ready to Commit | ⇒ | New |
Labels |
Added:
?
|
Merged into 2.5.x
. Thanks
Status | New | ⇒ | Closed |
Closed_Date | 2014-08-22 10:39:06 | ⇒ | 2014-08-31 17:59:50 |
JC Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33663&start=0