?

User tests: Successful: Unsuccessful:

avatar routinet
routinet
27 Apr 2014

plgContentLoadmodule::_loadmod() caches content it creates using just the module type as the index. If more than one module of the same type is included using {loadmodule}, whichever module renders first provides the content for all instances of that module type.

The fix uses a concatenation of the module type and title, providing a unique index.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar routinet routinet - open - 27 Apr 2014
avatar zero-24
zero-24 - comment - 27 Apr 2014

tested successfull good catch @routinet but please see my comment above. it is just a very smal one ;)

avatar bnisevic
bnisevic - comment - 31 May 2014

I tried to recreate the issue from http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33663&start=0 without applying the patch and I don't see any problem with it. I can not recreate the issue.

avatar routinet
routinet - comment - 1 Jun 2014

@bnisevic, this patch only applies to the use of {loadmodule} within other content. Using "normal" module placement through the template works as expected.

avatar rvbgnu
rvbgnu - comment - 26 Jul 2014

[Copy of tracker item]
test with Joomla 2.5.25-dev

I could not reproduce the issue. Here are additional test instructions, I may have missed the point:

  • (Created two modules of same type Feed Display in two different positions)
  • Create an article with the {loadposition} for each module

Content of my article:
ID 33663
First module id=87
{loadposition position-9}
Second module id=88
{loadposition position-10}

Did another test with positions not used in the template, with this article content:

ID 33663

First module id=87
{loadposition feed1}

Second module id=88
{loadposition feed2}

The two module content are displayed, and are different.

Please provide more instructions.
moving to "Information Required"

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - close - 22 Aug 2014
avatar brianteeman
brianteeman - comment - 22 Aug 2014

Thank you for your contribution and participation in the bug tracking process. As there has been no response to the request for further information I am closing this report at this time.

We have now moved our bug tracking process to http://issues.joomla.org/ so if you have further information that would enable this issue to be reopened please update the issue at http://issues.joomla.org/tracker/joomla-cms/3512 and it can be reopened.

avatar brianteeman brianteeman - change - 22 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-22 10:39:06
avatar brianteeman brianteeman - close - 22 Aug 2014
avatar routinet
routinet - comment - 22 Aug 2014

My apologies, been busy. rvbgnu's example used {loadposition}, not {loadmodule}. The issue is specific {loadmodule}

avatar brianteeman brianteeman - change - 22 Aug 2014
Status Closed New
avatar brianteeman brianteeman - reopen - 22 Aug 2014
avatar brianteeman brianteeman - reopen - 22 Aug 2014
avatar rvbgnu
rvbgnu - comment - 22 Aug 2014

Thanks for the precision @routinet. No need to apologise, that's me who read bad sometimes...

So I could reproduce the problem with two same type Custom HTML modules mod1 and mod2. Article content:

Testing issue #3512

{loadmodule mod_custom, mod1}

{loadmodule mod_custom, mod2}
```<br /><br />*This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="http://issues.joomla.org/">http://issues.joomla.org/</a>.*
avatar rvbgnu
rvbgnu - comment - 23 Aug 2014

@test
Work as expected! Thanks @routinet!

Please need a second test

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar zero-24
zero-24 - comment - 24 Aug 2014

if @routinet fix my coment above i think we can move this to RTC since the seccoend test by @rvbgnu

avatar routinet
routinet - comment - 24 Aug 2014

I'm not sure why the end braces are showing up on the same line - my edit did not include that change. How can I alter the PR?

avatar Bakual
Bakual - comment - 24 Aug 2014

How can I alter the PR?

If you're working with the GitHub UI, just navigate to the file in your own branch and edit it again. The PR will update. In that case it would be the following file:
https://github.com/routinet/joomla-cms/blob/2.5.x/plugins/content/loadmodule/loadmodule.php

avatar Bakual Bakual - change - 24 Aug 2014
Title
For issue #33663
loadmodule renders only first module of type
avatar Bakual
Bakual - comment - 24 Aug 2014

Adjusted PR title to be more clear.

avatar routinet
routinet - comment - 24 Aug 2014

Good to go

avatar zero-24 zero-24 - change - 24 Aug 2014
Status New Ready to Commit
avatar zero-24
zero-24 - comment - 27 Aug 2014

thanks @routinet :+1:

Can we have a RTC label on github? (JIssues status is now RTC) :D

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar Bakual Bakual - change - 27 Aug 2014
Status Ready to Commit New
Labels Added: ?
avatar Bakual Bakual - reference | ca9a687 - 31 Aug 14
avatar Bakual
Bakual - comment - 31 Aug 2014

Merged into 2.5.x. Thanks

avatar Bakual Bakual - change - 31 Aug 2014
Status New Closed
Closed_Date 2014-08-22 10:39:06 2014-08-31 17:59:50
avatar Bakual Bakual - close - 31 Aug 2014
avatar Bakual Bakual - close - 31 Aug 2014
avatar routinet routinet - head_ref_deleted - 6 Oct 2014

Add a Comment

Login with GitHub to post a comment