? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
14 Aug 2021

Pull Request for Issue # .
This is an addition to the PR #35093

Summary of Changes

Changed layout of categories list as tree. Also added an extra separator line on top of the first child

Testing Instruction

In the article categories, create some categories with some nested categories in it.
Add a description in every category and also add an image in the options tab.
Create a menu item of Articles -> List All Categories in an Article Category Tree
Make sure in the option tab that the categorie image and description are set to show.
To create the new CSS files run: npm run build:css

Actual result BEFORE applying this Pull Request

Image-3

Expected result AFTER applying this Pull Request

Image-4

Documentation Changes Required

avatar RickR2H RickR2H - open - 14 Aug 2021
avatar RickR2H RickR2H - change - 14 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2021
Category Repository NPM Change Front End com_content
avatar RickR2H RickR2H - change - 14 Aug 2021
Title
Fix layout
Fix layout article categories list as tree
avatar RickR2H RickR2H - edited - 14 Aug 2021
avatar joomdonation
joomdonation - comment - 14 Aug 2021

Thanks @RickR2H . Not having good experience with frontend code but could we have a way to re-use the css code here for other extensions ?

We have other components like com_contact, com_weblinks, com_newsfeeds use the same structure, so if we can use a generic class name instead of hardcode it to com_content, that would be better.

avatar RickR2H
RickR2H - comment - 14 Aug 2021

@joomdonation Yes it's generic and is on my todo list. If I find some time I'll try to implement the solution. @drmenzelit the animation in the accordion is gone by the way. Was this intended?

avatar ChristineWk ChristineWk - test_item - 14 Aug 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Aug 2021

I have tested this item successfully on a2033a7

It's nicer now as in previous PR :-)

@RickR2H What do you mean with: "the animation in the accordion is gone by the way."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

Rick: Bedankt hoor, leuk geworden zeg, he, he :-)

avatar ChristineWk
ChristineWk - comment - 14 Aug 2021

Result:

screen shot 2021-08-14 at 14 47 42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

avatar drmenzelit
drmenzelit - comment - 14 Aug 2021

@joomdonation Yes it's generic and is on my todo list. If I find some time I'll try to implement the solution. @drmenzelit the animation in the accordion is gone by the way. Was this intended?

The animation was probably part of Bootstrap. I was looking for a generic solution without Bootstrap so I didn't payed attention at that

avatar ricardo1709 ricardo1709 - test_item - 24 Aug 2021 - Tested successfully
avatar ricardo1709
ricardo1709 - comment - 24 Aug 2021

I have tested this item successfully on a2033a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

avatar ricardo1709
ricardo1709 - comment - 24 Aug 2021

I have tested this item successfully on a2033a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

avatar richard67 richard67 - change - 24 Aug 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35114.

avatar RickR2H
RickR2H - comment - 17 Oct 2021

@wilsonge Could you please take a look at this PR?

avatar chmst
chmst - comment - 17 Oct 2021
avatar bembelimen bembelimen - change - 13 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-13 23:21:12
Closed_By bembelimen
Labels Added: ? ? NPM Resource Changed
avatar bembelimen bembelimen - close - 13 Nov 2021
avatar bembelimen bembelimen - merge - 13 Nov 2021
avatar bembelimen
bembelimen - comment - 13 Nov 2021

Thx

Add a Comment

Login with GitHub to post a comment