[#35111] - fixed sidebar scroll issue
- Closed
- 22 Jan 2022
- Medium
- Build: 4.0-dev
- # 35111
- Diff
- pinak3748:sidebar
User tests: Successful: Unsuccessful:
Pull Request for Issue #35068
Summary of Changes
Currently, the left navigation expands and scroll down when you scroll the page. For example, if you have 20 components, you expand the components menu and click on the last link. The page loads with the last link down at the bottom of the page. you need to scroll down to see the bottom links.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
Are you sure you committed all the files that you wanted to change? there is nothing in the changes currently that could possibly make the navigation sticky or scrollable.
need more coffee
Untitled.mp4
It works in my system I think you forgot to npm ci or else try clearing cache of localhost
Mine also did not show any changes after clearing my localhost cache it workes
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35111.
The main content is now scrollable now without the sidebar, but it is more painful than earlier. The main issue is the sidebar was not scrolled to the last non-visible item, this fix made the content scrollable with stick sidebar. Now if I want to see the last menu item, I have to scroll the entire content before the sidebar scrolls. I would rather stick to an old design than this. A better approach would be scroll left sidebar to selected menu item when the page is loaded.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35111.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35111.
Request you to please relook at the issue that I raised before (the issue for which this PR was raised), this fix just aggravates the problem than fixing it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35111.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-22 11:47:24 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
Conflicting Files
?
?
|
||
I see it the same, we need a better solution for longer menus.
Although I close this PR, thank you for your contribution @pinak3748
I don't see any difference in functionality between RC6 and this. In both cases, the last menu link appears down at the bottom and need to scroll the page to see it.