? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
12 Aug 2021

Summary of Changes

Disable the critical plugins check for non-major updates for example when updating between 3.10 -> 3.10

Testing Instructions

Install 3.10-rc2
Install https://regularlabs.com/whatnothing
Use the nighly update server: https://update.joomla.org/core/nightlies/next_minor_list.xml

Set the update server to 4: https://update.joomla.org/core/nightlies/next_major_list.xml
than you get the warning again
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

cc @joomla/cms-release-team @HLeithner @bembelimen

avatar zero-24 zero-24 - open - 12 Aug 2021
avatar zero-24 zero-24 - change - 12 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2021
Category Administration com_joomlaupdate
avatar zero-24 zero-24 - change - 12 Aug 2021
The description was changed
avatar zero-24 zero-24 - edited - 12 Aug 2021
avatar alikon alikon - test_item - 13 Aug 2021 - Tested successfully
avatar alikon
alikon - comment - 13 Aug 2021

I have tested this item successfully on ad540f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35105.

avatar HLeithner HLeithner - change - 13 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-13 09:13:22
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 13 Aug 2021
avatar HLeithner HLeithner - merge - 13 Aug 2021
avatar zero-24
zero-24 - comment - 13 Aug 2021

Thanks 👍

avatar regularlabs
regularlabs - comment - 13 Aug 2021

Will the same be applied to the check in Joomla 4?

avatar zero-24
zero-24 - comment - 13 Aug 2021

On a quick look i would say no cause a plugin that is installed into 4.0 should have declared himself to be compatible with 4.0 right? Or do I miss something?

avatar regularlabs
regularlabs - comment - 13 Aug 2021

Not all extensions have (or can have) update sites attached to them. So the pre-update check is unable to check if it is compatible or not.
So that means you get warnings for every minor Joomla update.

Also: the same situation will present itself when there will be a Joomla 5...

avatar zero-24
zero-24 - comment - 13 Aug 2021

Ok fine for me than to adjust the check in 4.0 to do the check only for joomla 5 cc @wilsonge when you merge this one up.

Add a Comment

Login with GitHub to post a comment