User tests: Successful: Unsuccessful:
Project Repo PR: joomla-projects/gsoc21_core-enhancements#10
getListQuery()
method joins the old query with workflow_associations to also consider the workflow stages that belong to com_content.articles
only.COM_WORKFLOW_BASIC_WORKFLOW_MODULES
COM_WORKFLOW_BASIC_STAGE
com_modules
(Permanent similar to workflow assignment for com_content)
After a fresh install:
1, Go to Modules (Site or Admin) -> Options -> Integrations -> Enable Workflows
2. Test the transitions in modules view
3. Test CRUD for workflows, stages, and transitions in Modules: Workflows
4. Test Batch and Duplicate
Workflows are integrated into Modules and work as expected.
Possibly yes. Something on the lines of https://docs.joomla.org/Publishing_Workflow_Implementation#Implement_com_workflow_into_your_extension
@chmst @nibra @bembelimen
(And special thanks to @richard67)
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql com_content com_menus com_modules Language & Strings Installation Libraries |
Labels |
Added:
Language Change
?
|
Will test once 4,0 is out of the way
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
This cannot be merged until the the PHP level issue with heredoc is fixed.
I have tested this item
Not compatible with PHP 7.2 - see: https://github.com/joomla/joomla-cms/pull/35101/files#r775081165
Category | SQL Administration com_admin Postgresql com_content com_menus com_modules Language & Strings Installation Libraries | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
Oops, I rebased to 4.2-dev instead of 4.1
I'll revert and fix this.
Also, sorry for the review requests. I'm unable to remove them from my end.
Oops, I rebased to 4.2-dev instead of 4.1 I'll revert and fix this. Also, sorry for the review requests. I'm unable to remove them from my end.
@YatharthVyas You can remove review requests after having reverted the rebase (or rebased back) and then using the cog icon near the reviewers list on github.
Title |
|
Category | SQL Administration com_admin Postgresql Unit Tests Repository | ⇒ | Unit Tests SQL Administration com_admin Postgresql com_content com_menus com_modules Language & Strings Installation Libraries |
Labels |
Added:
?
?
Removed: ? |
Update: I have changed the base branch after discussing this with my mentors to 4.2-dev since being a new feature, this wont be going into 4.1
@richard67
Unfortunately, I'm still unable to remove the review requests. I dont know if I'm doing something wrong but the cog icon isnt visible for me
Category | SQL Administration com_admin Postgresql Unit Tests com_content com_menus com_modules Language & Strings Installation Libraries | ⇒ | SQL Administration com_admin Postgresql com_content com_menus com_modules Language & Strings Installation Libraries |
Labels |
Removed:
?
|
This pull requests has been automatically converted to the PSR-12 coding standard.
This pull request has been automatically rebased to 5.0-dev.
This pull request has been automatically rebased to 5.1-dev.
Title |
|
This pull request has been automatically rebased to 5.2-dev.
Title |
|
I have tested this item ? unsuccessfully on 1c3ad76
Applying the patch gave me a 500 error after saving and closing the module options. I am doing this on a live stream one of my viewers said "soo it look like the patch is out of date and needs to be updated before it's ready to test again."
Layout default_batch_footer not found.
Call Stack
1 () JROOT/libraries/src/MVC/View/HtmlView.php:425
2 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/administrator/components/com_modules/tmpl/modules/default.php:284
3 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
4 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
@cybersalt At the end of the page you find this information:
This means that the pull request can not be test until the conflicts are solved and the failed test is expected why it should be changed to "not tested" at the issue tracker.
This pull request has been automatically rebased to 5.3-dev.
Title |
|
Thanks for this PR.