? Success

User tests: Successful: Unsuccessful:

avatar ITPrism
ITPrism
26 Apr 2014

This patch adds the attribute "maxlength" to the form field "textarea".

Joomla!Code Tracker Page:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33661

avatar ITPrism ITPrism - open - 26 Apr 2014
avatar ITPrism ITPrism - change - 26 Apr 2014
Labels
avatar ITPrism ITPrism - change - 26 Apr 2014
Labels Added: ?
avatar ITPrism
ITPrism - comment - 26 Apr 2014

I see. I just use the code from the form field "text".
The purpose is to be similar with the code of the "text" field.
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/form/fields/text.php

I do not want to change the code of the person, which has done the project “Improve Form Fields”. :)
So, I will let you do it if you want. :)

avatar Achal-Aggarwal
Achal-Aggarwal - comment - 26 Apr 2014

LOL, I did that project. If you want I can edit both fields and maybe look others also for similar issues. What you say?

avatar ITPrism
ITPrism - comment - 26 Apr 2014

That will be great! :)
If you want, you can add other attributes.

  • placeholder
  • form
  • selectionDirection
  • selectionEnd
  • selectionStart
  • wrap

Check Valentin's replay on Joomla!Code Tracker Page 33661.

avatar wilsonge
wilsonge - comment - 27 Apr 2014

placeholder is there. Just it's been called hint

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar nicksavov nicksavov - change - 21 Aug 2014
Title
Missing form field attribute "maxlength".
[#33661] Missing form field attribute "maxlength".
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar ITPrism ITPrism - change - 21 Aug 2014
Title
Missing form field attribute "maxlength".
[#33661] Missing form field attribute "maxlength".
avatar brianteeman brianteeman - change - 2 Sep 2014
Category Libraries
avatar Robdebert
Robdebert - comment - 10 Nov 2014

" All is well — The Travis CI build passed " <- is there anything still left open? I refer to this: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33661 where Valentin says, that not enough testing was done and so it does not get implemented in the next version(s)

if you need more code-reviews / testing, i'll be happy to help.

avatar Bakual
Bakual - comment - 10 Nov 2014

Travis is the automated testing. It can detect some code errors, but doesn't detect every error.
We always need manual testing for things to get merged. Usually at least two successful tests should be logged in the issue tracker (http://issues.joomla.org) before something is considered "ready to commit". From there someone will review the code and merge it.

avatar isidrobaq isidrobaq - test_item - 18 Dec 2014 - Tested successfully
avatar isidrobaq
isidrobaq - comment - 18 Dec 2014

I tested the proposed patch, and worked as described for me. So here's a "successful test" for this one :).

What's the status for this issue? Maybe would be able to do it into 3.4 if another successful test comes?

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3510.

avatar infograf768
infograf768 - comment - 18 Dec 2014

as stated above this needs some small improvements

avatar zero-24
zero-24 - comment - 3 May 2015

@ITPrism can you implement the changes that was suggsested by @Achal-Aggarwal in the inline comments? So we can move this forward? Thanks :smile:

avatar bertmert
bertmert - comment - 6 May 2015

I think this issue is fixed already by RTC PR #6460 that will be applied in J!3.5.0

avatar wilsonge
wilsonge - comment - 25 May 2015

I have merged #6460. If there are any futher issues can you open a new PR please?

avatar wilsonge wilsonge - change - 25 May 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-05-25 00:27:43
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 May 2015

Add a Comment

Login with GitHub to post a comment