? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
12 Aug 2021

Summary of Changes

make com_search work on J4

Testing Instructions

apply pr
upgrade to j4

Actual result BEFORE applying this Pull Request

com_search doesn't work

Expected result AFTER applying this Pull Request

com_search works in j4

Documentation Changes Required

?

avatar alikon alikon - open - 12 Aug 2021
avatar alikon alikon - change - 12 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2021
Category Administration com_search Front End Plugins
avatar brianteeman
brianteeman - comment - 12 Aug 2021

I thought com_search was removed ?

avatar alikon
alikon - comment - 12 Aug 2021

it is removed from new installation , but if you upgrade from a j3 site .....

avatar wilsonge
wilsonge - comment - 12 Aug 2021

The intention was that people should update to the decoupled com_search here https://github.com/joomla-extensions/search/tree/4.0-dev similar to how we did weblinks.

avatar zero-24
zero-24 - comment - 12 Aug 2021

Yes the only thing we would to do in an ideal world would be to add the update server into 3.10 and make sure it is detected as 3rd party extension at the time of the upgrade checks.

avatar zero-24
zero-24 - comment - 12 Aug 2021

or even better add the update xml into 4.0 as the upgrade works and the new version will be 4.x only anyway.

That would mean 3.10 -> 4.0 -> com_search update like all other 3rd party extensions that are no longer 3.x compatible would go,

avatar alikon
alikon - comment - 12 Aug 2021

plus there is no information about com_search nor com_search version j4

Screenshot from 2021-08-12 10-22-18

avatar richard67
richard67 - comment - 12 Aug 2021

The intention was that people should update to the decoupled com_search here https://github.com/joomla-extensions/search/tree/4.0-dev similar to how we did weblinks.

@wilsonge We did weblinks? You mean it is ready for J4? If so then I missed something. To me the weblinks repository seems to be abandoned. No PR gets merged there, CI checks broken since months.

avatar zero-24
zero-24 - comment - 12 Aug 2021

Hmm when the code provided here makes com_search work I would say the correct way forward would be to do a PR against: https://github.com/joomla-extensions/search/tree/4.0-dev/src

Once merged there do a release and add the new update server on updating from 3.10.

So after updating to 4.0 the update shows up and the package can be used with the package that works with 4.0

avatar alikon alikon - change - 13 Aug 2021
Labels Added: ?
avatar alikon
alikon - comment - 13 Aug 2021

Hmm when the code provided here makes com_search work

that's easy, simply test it

the correct way forward would be to do a PR against: https://github.com/joomla-extensions/search/tree/4.0-dev/src

there is no need to do this pr there, it's a complete new rewrite in j4 style already

this pr just give us the time to do:

  • do a release
  • add the new update server
  • etc

things that hardly can be done until 17

avatar alikon alikon - change - 13 Aug 2021
Labels Added: ?
Removed: ?
avatar zero-24
zero-24 - comment - 17 Aug 2021

Hi, this PR is the base for the minimal version of search running on 4.0 that we have called and published as 4.0.0-dev here: https://github.com/joomla-extensions/search/releases/tag/4.0.0-dev to be used until a more final package of search has been build.

Thanks @alikon for providing this PR ?

avatar zero-24 zero-24 - change - 17 Aug 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-08-17 02:44:02
Closed_By zero-24
Labels Added: ?
Removed: ?
avatar zero-24 zero-24 - close - 17 Aug 2021

Add a Comment

Login with GitHub to post a comment