? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Aug 2021

Pull Request for Issue #35089

Summary of Changes

Patch syntax errors on lower PHP Versions

Testing Instructions

Test the EOS plugin on PHP 7.0.7 or lower

Actual result BEFORE applying this Pull Request

syntax error, unexpected ')'

Expected result AFTER applying this Pull Request

No syntax error

Documentation Changes Required

none

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar zero-24 zero-24 - open - 11 Aug 2021
avatar zero-24 zero-24 - change - 11 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2021
Category Front End Plugins
avatar eddiekonczal
eddiekonczal - comment - 11 Aug 2021

I just installed this patch and it resolves the problem.

avatar zero-24
zero-24 - comment - 11 Aug 2021

Thanks, will try to add a drone step later that adds a php5.3 linter that i thought would be already there :)

avatar richard67
richard67 - comment - 11 Aug 2021

@eddiekonczal Could you mark your test result as successful so it counts? Just go to https://issues.joomla.org/tracker/joomla-cms/35091 , use the "Test this" button and then submit. I could also set the test result for you if you can't do that for some reason, just let me know here if that is the case. But I thought I'd let you know how it works in case if you test more bug fixes in future. Thanks in advance.

avatar richard67 richard67 - test_item - 11 Aug 2021 - Tested successfully
avatar richard67
richard67 - comment - 11 Aug 2021

I have tested this item successfully on 4509b46

Code review: The function call might look similar to array() syntax at a first look, so maybe that's why one had added that wrong comma, because for array() it would be ok. But here we have function calls so the comma is wrong with ANY PHP version.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.

avatar eddiekonczal eddiekonczal - test_item - 11 Aug 2021 - Tested successfully
avatar eddiekonczal
eddiekonczal - comment - 11 Aug 2021

I have tested this item successfully on 4509b46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.

avatar eddiekonczal
eddiekonczal - comment - 11 Aug 2021

@richard67 - I just marked my test result as successful.

Will the patch be included in a future nightly build, or will we need to manually install the patch on each site that needs it?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.
avatar richard67 richard67 - change - 11 Aug 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 11 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.

avatar richard67
richard67 - comment - 11 Aug 2021

Will the patch be included in a future nightly build, or will we need to manually install the patch on each site that needs it?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.

@eddiekonczal It will be included in nightly build after it has been merged. But since this is a release blocker and @zero-24 is the release lead I expect this to happen soon.

avatar zero-24 zero-24 - change - 11 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-11 20:02:27
Closed_By zero-24
Labels Added: ? ? ?
Removed: ? ?
avatar zero-24 zero-24 - close - 11 Aug 2021
avatar zero-24 zero-24 - merge - 11 Aug 2021
avatar zero-24
zero-24 - comment - 11 Aug 2021

Merged thanks ? so it will be fixed with the next nighly build

Add a Comment

Login with GitHub to post a comment