User tests: Successful: Unsuccessful:
Pull Request for Issue #35089
Patch syntax errors on lower PHP Versions
Test the EOS plugin on PHP 7.0.7 or lower
syntax error, unexpected ')'
No syntax error
none
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Thanks, will try to add a drone step later that adds a php5.3 linter that i thought would be already there :)
@eddiekonczal Could you mark your test result as successful so it counts? Just go to https://issues.joomla.org/tracker/joomla-cms/35091 , use the "Test this" button and then submit. I could also set the test result for you if you can't do that for some reason, just let me know here if that is the case. But I thought I'd let you know how it works in case if you test more bug fixes in future. Thanks in advance.
I have tested this item
Code review: The function call might look similar to array()
syntax at a first look, so maybe that's why one had added that wrong comma, because for array()
it would be ok. But here we have function calls so the comma is wrong with ANY PHP version.
I have tested this item
@richard67 - I just marked my test result as successful.
Will the patch be included in a future nightly build, or will we need to manually install the patch on each site that needs it?
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
?
|
RTC
Will the patch be included in a future nightly build, or will we need to manually install the patch on each site that needs it?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35091.
@eddiekonczal It will be included in nightly build after it has been merged. But since this is a release blocker and @zero-24 is the release lead I expect this to happen soon.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-11 20:02:27 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
?
?
Removed: ? ? |
Merged thanks
I just installed this patch and it resolves the problem.