[#35086] - [4][webservices] - patch article strip html tags
- Fixed in Code Base
- 23 Jan 2022
- Medium
- Build: 4.0-dev
- # 35086
- Diff
- alikon:patch-121
User tests: Successful: Unsuccessful:
Pull Request for Issue #34933 .
Summary of Changes
don't strip all the html tags use the filter
Testing Instructions
PATCH an introtext and /or fulltext
curl --location --request PATCH 'http://[yoursite]/index.php/v1/content/articles/54' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer [yourkey]' \
--data-raw '{
"title":"Test PATCH",
"introtext": "<p><strong>Bold </strong><em>Italic </em><span style=\"text-decoration: underline;\">underscore </span><span style=\"text-decoration: line-through;\">striketrough</span> <span style=\"color: #ff0000;\">Red</span></p>",
"fulltext": "adfkjvgh kdkjsfhdkjs ghkdfgkjdfh jdfvgdkjf vdkj gdkfjghkdjfghdkfjghdkj gdkfghdkjf hgdkfgh kdfk kjghkdgd de<p><strong>Bold </strong><em>Italic </em></p>"
}'
Actual result BEFORE applying this Pull Request
all html tags in an introtext and /or fulltext are stripped out on PATCH
Expected result AFTER applying this Pull Request
the PATCH works as expected
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
I have tested this item
Tested on Ubuntu 20.04 LTS Desktop PHP 7.4.22 MySQL 8.0.26 works as expected successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
Hi @alikon,
How can I get involved in the webservices space?
Just show up and make a pull request ? Or is there more to it.
Talk to the rest of the webservices working group first?
Thanks for your awesome dedicated hard work
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
How can I get involved in the webservices space?
Just show up and make a pull request ?
making a PR is insanely appreciate , by me at least
Talk to the rest of the webservices working group first?
there is no working group that i'm aware of, maybe we should build one
p.s
thanks for testing
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
J4 Issue
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending since @wilsonge requested updates.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
| Labels |
Added:
?
?
Removed: J4 Issue |
||
ok so, as the documentation is not clear, we need to use only introtext and fulltext and not articletext
I have tested this item
Verified this PR by sending a PATCH request with updated introtext and/or fulltext, all html tags get preserved and the page gets updated as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
Patch is successful with caveats
instead of using text or articletext the correct variables are introtext and fulltext.
To note in one test both introtext & fulltext did not work together but worked successfully when patching them separately. I concluded that only happened when updating text that was entered into site editor manually and not designated intro or full text.
Subsequently, introtext and fulltext work successfully in all other cases.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
Hi! When is this PR going to be merged? It's very inconvenient to remember and apply this fix manually every time I start a new project.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-23 06:11:36 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
Removed: ? |
||
Thx
I have tested this item✅ successfully on 68cbd24
Patch works! Had to change the URL and add api before index: to http://[yoursite]/api/index.php/v1/content/articles/54'
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35086.