User tests: Successful: Unsuccessful:
Automatically created pull request based on core-translation repository changes
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Installation Language & Strings |
Can't there be some automated testing of the XML/INI files for specific language to see if the files actually work before submitting the PR?
Or at least only include files which are 100% translated/proofread.
In J3, the TTs usually test their language before they submit the files and I do a visual check for obvious errors before creating the PR.
Or at least only include files which are 100% translated/proofread.
I support this. There is no point in empty directories / files.
installation/language/fr-CA/langmetadata.xml
is also totally wrong and surely more...
Also, no language should be added to the installation folder until one is sure a language pack will be provided.
Labels |
Added:
Language Change
?
|
Yes we know that there are many errors in the metadata files and we are looking forward to find a solution. But that's the export form crowdin translation done (or not done) by the translators.
For brians example: https://joomla.crowdin.com/translate/b2a99ed5361a855bf12c46fc7ced2775/4177/en-enau/88?filter=basic&value=0
can't check the link as it requires a crowdin account.
as long as this stuff is not automatically merged and there is human intervention then its fine. Although it might be easier, if possible, for each language to be a pr instead of them all as one.
Although it might be easier, if possible, for each language to be a pr instead of them all as one.
This will probably only be an issue with this initial PR. After that, the changes will usually be minor ones as it is the same added string for the various languages or similar.
What may become interesting is that such a PR is created/updated each time TTs make changes to the strings. When I tested the integration in the past, there were fast (rightfully) complaints about the spam it created. But it also was for the whole CMS, not only the installation language files. So this integration here should be much less problematic.
Labels |
Added:
?
Removed: ? |
@joomla-translation-bot de-LU is missing while the other de Languages are added in with this PR.
@zero-24 talking to a bot could be a sign of loneliness^^ I forwarded this to wilco but you may check the script at https://github.com/joomla/core-translation repository.
For now that's the final files for 4.0.0 (when de-LU is added). I did only a quick check but looks good for me, CI also works now. If someone else would have a look I would be happy.
The xml looks better now. I see a few formatting issues but I doubt they are a problem
From my understanding there are some inaccuracies or even errors in the xml - they dont impact installation and its probably just a lack of documentation/instruction to the language teams
For example the year of the copyright and the nativeName
<nativeName>French (France)</nativeName>
Shouldn't that be
<nativeName>français (France)</nativeName>
However there is one issue with many language packs (including all the german ones)
The documentation for licences etc jdocs states
Copyrights are both Open Source Matters and author's
So my understanding of that is that this is compliant
<copyright>Copyright (C) 2005 - 2021 Open Source Matters & Dr. Ashraf Damra/Abu Nidal. All rights reserved.</copyright>
But these ones definitely are not
<copyright>(C) 2008 - 2021 J!German. All rights reserved.</copyright>
<copyright>(C) 2008 - 2021 J!Club. All rights reserved.</copyright>
Is this an issue in the current J3 files out of interest?
Agree other part is an education effort. I suspect XML files we might be better served eventually by having these as borderline static in the repo as opposed to passed through crowdin but that's a longer term thing.
J3 Language file for French has the correct nativeName
<nativeName>Français (France)</nativeName>
J3 Language file for de-DE has the correct copyright
<copyright>(C) 2005 Open Source Matters, Inc.</copyright>
In J3, I always checked and corrected the copyright to be OSM.
And yes, the nativeName should be Français (France)
, not French (France)
. However I'm not sure it is even used in the installation language files.
I have tested this item
And yes, the nativeName should be
Français (France)
, notFrench (France)
. However I'm not sure it is even used in the installation language files.
Used in the page /administrator/index.php?option=com_languages&view=installed where the common and native title is displayed.
Labels |
Added:
?
Removed: ? |
In J3, I always checked and corrected the copyright to be OSM.
And yes, the nativeName should be
Français (France)
, notFrench (France)
. However I'm not sure it is even used in the installation language files.
france fixed, waiting for german (all languages) copyright updates from upstream repository, since these languages are not in crowdin we have to wait for jgerman (and swiss?) upstream repository.
If copyright can't be solved we have to remove the translations
Will send an update for german once i get back to my desk tomorrow.
PR has been send: joomla/core-translations#20
Labels |
Added:
?
Removed: ? |
One has to check the files provided and this is not possible with an automatic script: see my comments.
The Copyright and License should NOT be available for translation in Crowdin.
I have tested this item
One has to check the files provided and this is not possible with an automatic script: see my comments.
@infograf768 can you look at joomla/core-translations#22 it prevent translate strings that should not be translated by the translator^^
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
I'm closing this PR because I broke the branch...
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-12 12:17:23 |
Closed_By | ⇒ | HLeithner |
There is a problem with this automatic generated PR and the best example is in the language files for af-ZA but there are a lot of other similar problems in other languages