[#35079] - Fix body overflow in dashboard due to dropdown
- Fixed in Code Base
- 4 Sep 2021
- Medium
- Build: 4.0-dev
- # 35079
- Diff
- RickR2H:fix-module-dropdown
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When the cogs icon is clicked to edit or unpublish a module in the dashboard, it creates an overflow of the body, This patch adds an overflow hidden to the module to prevent this.
Testing Instructions
Apply the patch, build the CSS and click on one of the cogs icons in the dashboard. The body should not overflow.
Actual result BEFORE applying this Pull Request
Body has an overflow (See screenshot)
Expected result AFTER applying this Pull Request
Overflow fixed.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
I agree this works to fix the problem but wouldnt it be better to find out what is causing it and preventing it from happening
@brianteeman I agree that would be the best option if there is one.
But as browsers behave differently, I think this is the most logical fix. Probably it has something to do with the popper script.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
data-bs-display="static" on the dropdown button trigger will fix it.
You're then also going to want to remove:
.com_cpanel .module-actions > * {
margin-top: -10px;
}
| Labels |
Added:
?
?
|
||
@C-Lodder Thanks for the info and your proposed fix works. I updated my PR. @richard67 please remove RTC until new tests.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
@sandewt @richard67 please test again
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
I have tested this item
Google Chrome, versie 92.0.4515.131 (Officiële build) (64-bits)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.
Is this PR still relevant? I can't reproduce the issue...
@bembelimen I use Chrome. Hope this gif will clear things up a bit.
@bembelimen I can confirm that. I could only reproduce it with Google Chrome here, not with Firefox.
Ah it's Browser related, yes I see it now, too. Thanks.
| Labels |
Added:
?
?
Removed: ? ? |
||
In my last commit the header text and icon are vertically centered. Also there was a margin difference on really small screens, Made it consisted on all breakpoints.
@bembelimen When will this PR be merged? It is clearly a bug that needs to be patched.
As long as it is done before the next release it doesn't matter, or not?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-04 04:29:52 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
Removed: ? |
||
Thx
I have tested this item✅ successfully on 46f8bfb
Note: I could not reproduce the issue with Firefox 90.0.2 (64-Bit) for Windows, but I could reproduce it with Google Chrome 92.0.4515.131 (64-Bit) for Windows.
The patch of this PR fixes the issue for Chrome, and Firefox works as before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35079.