? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
8 Aug 2021

Pull Request for #34962 (comment) .

Summary of Changes

This pull request (PR) adds the "/media/system/images" to the list of directories to be skipped here https://github.com/richard67/joomla-cms/blob/de82cb7a1f7053106274f06f3627d0a287e74116/build/deleted_file_check.php#L63-L75 so that the lists of deleted files and folders generated by "build/deleted_file_check.php" will not contain that folder and its subfolders and all their files.

As it was decided in PR #34962 not to delete the old images on updates, this PR here removes files and folders from the files and folders deletion in "administrator/components/com_admin/script.php" which had been added to these lists at the very beginning of J4 development.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

The lists of files and folders to be deleted which are generated with "build/deleted_file_check.php" contain the files which have been deleted with PR #34962 and their parent folders.

The files and folder deletion in "administrator/components/com_admin/script.php" doesn't and shouldn't contain these files and folders. But it contains other files and a folder below "/media/system/images".

That means we either have a permanent inconsistency between the generated lists and those which are finally used, or we have to maintain in "build/deleted_file_check.php" each single file to be kept below the "/media/system/images" folder now and in future.

Expected result AFTER applying this Pull Request

Neither the lists of files and folders to be deleted which are generated with "build/deleted_file_check.php" nor the finally used lists in "administrator/components/com_admin/script.php" contain the "/media/system/images" folder or any folder or file below that folder.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 8 Aug 2021
avatar richard67 richard67 - change - 8 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2021
Category Administration com_admin Repository
avatar Fedik Fedik - test_item - 8 Aug 2021 - Tested successfully
avatar Fedik
Fedik - comment - 8 Aug 2021

I have tested this item successfully on de82cb7

looks good


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35070.

avatar richard67 richard67 - change - 8 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 8 Aug 2021
avatar wilsonge wilsonge - change - 8 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-08 11:23:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 8 Aug 2021
avatar wilsonge wilsonge - merge - 8 Aug 2021
avatar wilsonge
wilsonge - comment - 8 Aug 2021

Thanks!

avatar richard67
richard67 - comment - 8 Aug 2021

Thanks.

Add a Comment

Login with GitHub to post a comment