[#3507] - [#33480] Number form-field
- Closed
- 9 Jun 2014
- Medium
- Build: staging
- # 3507
- Diff
- izharaazmi:patch-1
- Foreign ID 33480
- Success The Travis CI build passed Details
User tests: Successful: 0 Unsuccessful: 0
Allow "zero" max/min & remove default limits in JFormFieldNumber
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
I don't see anything wrong with your PR. It even already has one successful test.
Usually we want two tests before we merge anything.
One thing to note for future PRs is that you should limit it to one issue. You're doing two fixes here. That makes it harder to test it.
To get more testers it usually helps if you can provide as detailled steps as possible. Always think of the testers as regular users without development skills. The better you guide them, the faster you have the tests 
Thanks, got your point.
So what do you suggest, should I split this into two PRs?
However in current case only the number field issue is major. Another is
just one liner error message display correction.
If you can, yes please split it in two PRs. Leave this one for the number stuff and do a new one for the error message. That would be great.
| Title |
|
||||||
Just rolled back to stay on number-field issue only. Build succeeded.
Thanks!
phproberto
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-09 01:43:30 |
I would like to draw attention of the core team towards this. If there are any issue related to my changes a feedback would be appreciated from anybody there.