? Success

User tests: Successful: 0 Unsuccessful: 0

avatar izharaazmi
izharaazmi
26 Apr 2014

Allow "zero" max/min & remove default limits in JFormFieldNumber

Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33480&start=0

avatar izharaazmi izharaazmi - open - 26 Apr 2014
avatar izharaazmi izharaazmi - change - 26 Apr 2014
Title
Number form-field and JControllerAdmin::publish
[#33480] Number form-field and JControllerAdmin::publish
avatar izharaazmi izharaazmi - change - 26 Apr 2014
Title
Number form-field and JControllerAdmin::publish
[#33480] Number form-field and JControllerAdmin::publish
Labels Added: ? ?
avatar izharaazmi
izharaazmi - comment - 7 Jun 2014

I would like to draw attention of the core team towards this. If there are any issue related to my changes a feedback would be appreciated from anybody there.

avatar Bakual
Bakual - comment - 7 Jun 2014

I don't see anything wrong with your PR. It even already has one successful test.
Usually we want two tests before we merge anything.

One thing to note for future PRs is that you should limit it to one issue. You're doing two fixes here. That makes it harder to test it.

To get more testers it usually helps if you can provide as detailled steps as possible. Always think of the testers as regular users without development skills. The better you guide them, the faster you have the tests :smile:

avatar izharaazmi
izharaazmi - comment - 7 Jun 2014

Thanks, got your point.
So what do you suggest, should I split this into two PRs?
However in current case only the number field issue is major. Another is
just one liner error message display correction.

avatar Bakual
Bakual - comment - 7 Jun 2014

If you can, yes please split it in two PRs. Leave this one for the number stuff and do a new one for the error message. That would be great.

avatar izharaazmi izharaazmi - change - 7 Jun 2014
Title
[#33480] Number form-field and JControllerAdmin::publish
[#33480] Number form-field
avatar izharaazmi
izharaazmi - comment - 7 Jun 2014

Just rolled back to stay on number-field issue only. Build succeeded.

avatar Bakual
Bakual - comment - 7 Jun 2014

Thanks!

avatar phproberto phproberto - reference | 1c11979 - 9 Jun 14
avatar phproberto phproberto - close - 9 Jun 2014
avatar phproberto phproberto - change - 9 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-09 01:43:30
avatar phproberto phproberto - close - 9 Jun 2014
avatar izharaazmi izharaazmi - head_ref_deleted - 9 Jun 2014
avatar izharaazmi izharaazmi - head_ref_restored - 12 Jun 2014

Add a Comment

Login with GitHub to post a comment