[#35063] - 4.0 dev update bootstrap library
- Closed
- 7 Aug 2021
- Medium
- Build: staging
- # 35063
- Diff
- joomla:4.0-dev
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success continuous-integration/drone/push Build is passing Details
User tests: Successful: Unsuccessful:
update bootstrap library to 5.1
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration |
@1337180 Your PR should be for the 4.0-dev branch but you have made it for the staging branch. Therefore it shows over 5 thousand changed files. You should have noticed that.
Furthermore you should have checked if npm ci works after updating bootstrap from 5.0.2 to 5.1.0. I did that here and it failed.
So I'm in doubt if you have tested your changes.
Finally, we already are on it to update BS to 5.1 but it seems it requires changes on our scss do adapt to the changes from 5.0.2 to 5.1.
Closing because it's for the wrong branch.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-07 07:57:52 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
@richard67 all this pr did was to merge 4.0 and staging - there was nothing created by the author
Finally, we already are on it to update BS to 5.1 but it seems it requires changes on our scss do adapt to the changes from 5.0.2 to 5.1.
To be fair they are not a mind-reader so they wouldnt know anyone was doing that
Please close