? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
6 Aug 2021

Pull Request for Issue # .

Summary of Changes

In package.json we currently have "joomla-ui-custom-elements": "0.2.0", but in package-lock.json we have "joomla-ui-custom-elements": "0.1.0 ",:

https://github.com/joomla/joomla-cms/blob/4.0-dev/package.json#L48

https://github.com/joomla/joomla-cms/blob/4.0-dev/package-lock.json#L27

So it seems that the change from PR #34813 later got lost, possibly when merging PR #34888 .

This means if you work on the current 4.0-dev branch you still have version 0.1.0 of custom elements after an npm ci, but after an npm install you would have version 0.2.0.

This pull request (PR) here fixes that.

One way how this could have happened is that the latter PR had a conflict for the package-lock.json when it was merged. Or something else happened later.

=> Ping @wilsonge .

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

In package-lock.json we have "joomla-ui-custom-elements": "0.1.0 ",, and so nightly build packages contain that version of Custom Elements, and the next RC will contain it, too, if this PR here will not be merged before, and so the changes from PR #34813 might not work.

Expected result AFTER applying this Pull Request

Custom Elements version 0.2.0 being used.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 6 Aug 2021
avatar richard67 richard67 - change - 6 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2021
Category NPM Change
avatar richard67 richard67 - change - 6 Aug 2021
Title
[4.0] Fix incomplete npm update of custom elements
[4.0] Fix missing npm update of custom elements
avatar richard67 richard67 - edited - 6 Aug 2021
avatar richard67 richard67 - change - 6 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 6 Aug 2021
avatar richard67
richard67 - comment - 6 Aug 2021

As PR #34813 was a release blocker and this PR restores the partly lost change from that PR, this here is a release blocker in my opinion.

avatar richard67 richard67 - change - 6 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 6 Aug 2021
avatar richard67 richard67 - change - 6 Aug 2021
The description was changed
avatar richard67 richard67 - edited - 6 Aug 2021
avatar wilsonge wilsonge - close - 6 Aug 2021
avatar wilsonge wilsonge - merge - 6 Aug 2021
avatar wilsonge wilsonge - change - 6 Aug 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-06 10:32:34
Closed_By wilsonge
Labels Added: ? ? NPM Resource Changed
avatar richard67
richard67 - comment - 6 Aug 2021

Thanks!

Add a Comment

Login with GitHub to post a comment