[#35056] - [4.0] Fix state filter options in workflows manager
- Fixed in Code Base
- 1 Nov 2021
- Medium
- Build: 4.0-dev
- # 35056
- Diff
- ditsuke:patch-wf
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes the options on display by using the right optionsFilter attribute instead of filter.
Testing Instructions
Go to the workflow manager for some extension, for example yoursite.example/index.php?option=com_workflow&extension=com_content
Actual result BEFORE applying this Pull Request
The state filter lists states not supported by com_workflows
Expected result AFTER applying this Pull Request
The state filter only lists states supported by com_workflows (the labels are still not right)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
@richard67 I didn't catch those! Getting them in soon.
| Labels |
Added:
?
|
||
As an aside, would you say we can use a StatusField attribute to use JENABLED/JDISABLED instead?
I see com_plugins uses its own field because of this and here in Workflows we have the wrong labels (the item view uses a ListField instead).
On the other end over in Cronjobs I'm also using a custom field at the moment to get it right.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35056.
Good spot.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35056.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35056.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35056.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-01 13:13:40 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
Removed: ? |
||
Thanks
Thanks
@ditsuke Shouldn't that be done too for the transitions list and the stages list of the workflow?