?

User tests: Successful: Unsuccessful:

avatar danslo
danslo
25 Apr 2014

This is a backport to the 2.5 branch, see the following:

791f561

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar danslo danslo - open - 25 Apr 2014
avatar danslo
danslo - comment - 20 May 2014

Is this repository monitored at all? Any feedback?

avatar Bakual
Bakual - comment - 20 May 2014

It's monitored, but we don't automatically merge PRs for 2.5 if something is applied to 3.x.
You need a tracker and likely also some tests here as well.

Try to give details and don't expect people to follow a link to a commit elsewhere.

On a sidenote: Joomla 2.5 will reach end of life by the end of this year. So the interest in it is probably already declining a bit.

avatar danslo
danslo - comment - 20 May 2014

From the commit above:

Make JEventDispatcher compatible with HHVM
According to HHVM inconsistencies guildline, "Under Zend PHP, foreach by value will modify the array's internal cursor under certain circumstances. Under HipHop VM, foreach by value will never modify the array's internal cursor.

Moving end() from above key() function to below it also make the code easier to understand as the behavior of foreach with array cursor is complicated to understand.

I am not involved enough in Joomla development to write tests for this. @mbabker merged it in 3.x here: http://issues.joomla.org/tracker/joomla-cms/3199

avatar Bakual
Bakual - comment - 20 May 2014

I was not referring to unit tests, usually we need human testers to see if nothing breaks.
Lets see if Michael wants to merge this as well based on code review :)

avatar mbabker
mbabker - comment - 20 May 2014

Must have missed seeing this PR honestly with everything I've had going on over the last few weeks. I'll merge it.

avatar mbabker mbabker - change - 20 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-20 15:27:00
avatar mbabker mbabker - close - 20 May 2014
avatar mbabker mbabker - reference | - 20 May 14
avatar mbabker mbabker - merge - 20 May 2014
avatar mbabker mbabker - close - 20 May 2014
avatar danslo
danslo - comment - 20 May 2014

No hard feelings, thank you for the quick response after the bump!

avatar danslo danslo - head_ref_deleted - 20 May 2014
avatar beat
beat - comment - 20 May 2014

Understand this is a backport. But still wondering by curiosity why end() is not also called when returning inside a foreach loop ?

Add a Comment

Login with GitHub to post a comment