? Pending

User tests: Successful: Unsuccessful:

avatar Krshivam25
Krshivam25
5 Aug 2021

Pull Request for Issue #26317

Summary of Changes

Added Aria-invalid in the login form.

Testing Instructions

Actual result BEFORE applying this Pull Request

If you call the login page with a screenreader and click into the login field, the screen reader reports that the input is invalid.

Expected result AFTER applying this Pull Request

aria-invalid can also be used to indicate that a required field has not been filled in. The attribute should be programmatically set as a result of a validation process.

Documentation Changes Required

no

avatar Krshivam25 Krshivam25 - open - 5 Aug 2021
avatar Krshivam25 Krshivam25 - change - 5 Aug 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2021
Category Modules Front End
avatar brianteeman brianteeman - test_item - 5 Aug 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 5 Aug 2021

I have tested this item ? unsuccessfully on 5f41c24

This doesn't work because you are changing the wrong module. Also please read all the comments on the original issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35046.

avatar brianteeman
brianteeman - comment - 6 Aug 2021

Please close - this is completely wrong and even if the code was correct its on the wrong file in the wrong module. Keeping it open just wastes testers time. It can always be re-opened if it is corrected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35046.

avatar Krshivam25 Krshivam25 - change - 6 Aug 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-08-06 16:00:22
Closed_By Krshivam25
Labels Added: ?
avatar Krshivam25 Krshivam25 - close - 6 Aug 2021

Add a Comment

Login with GitHub to post a comment