[#35017] - [4.0] Make note field hideable
- Fixed in Code Base
- 9 Sep 2021
- Medium
- Build: 4.0-dev
- # 35017
- Diff
- ReLater:patch-2
User tests: Successful: Unsuccessful:
Fixes #35016
Summary of Changes
- load bootstrap.alert if necessary.
- change wrong attribute
data-dismisstodata-bs-dismiss - use class
data-dismissibleto right align close button - remove
×to avoid a doubleXin button
Testing Instructions
- Please see #35016
Actual result BEFORE applying this Pull Request
- Alert didn't close when dismiss button clicked
Expected result AFTER applying this Pull Request
- Alert does close when dismiss button clicked
- Correctly styled alert
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35017.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35017.
I know it's a bit out of scope (and this field is really ugly), but probaly when you're at it, would it be possible to make the alert looking more as "our" alerts?
Like the close button:
or the beginning:
Probably it's a quick fix?
For me it's just a note/description/info that has a class "alert" because these CSS classes provide ready-to-use styling, contrasts(!) and so on, not really alerts. For me, they are OK as they are in this environment.
And I prefer well documented, simple Bootstrap styling that is Joomla 3 and Joomla 4 compatible in this case, instead of overloaded here-and-there-more-classes if I want to change the look of these fields.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-09 17:13:34 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
Removed: ? |
||
Thanks. @bembelimen it's out of scope for here. But moving to the custom element isn't a bad idea. Let's try and get a separate PR for that (maybe target 4.1)
I have tested this item✅ successfully on 6e87158
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35017.