[#35004] - [4.0] Cassiopeia - Possible solution for main content height
- Closed
- 2 Aug 2021
- Medium
- Build: 4.0-dev
- # 35004
- Diff
- drmenzelit:4.0-dev-height
User tests: Successful: Unsuccessful:
Pull Request for Issue #35003 .
Summary of Changes
Removed debug area for mobile view (I missed that on my last PR)
Added a grid-template-rows definition to make the main content part 1fr in height
Testing Instructions
See issue #35003 and description of PR #34849
Please test with and without modules and content and in different display sizes. Also test with short content and some module in footer position.
Actual result BEFORE applying this Pull Request
See issue
Expected result AFTER applying this Pull Request
The main content is aligned to top no matter if no content is present.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35004.
Problem now is that the bottom positions are also pushed down.
The best way is my option 2 ;)
Tried one with demo data. I removed the text from Typography and deactivated the main menu on the right side.
If you want to have an error, you won't get it. :-)
Got this result (without Patch:)
Sorry, must stop now. Heavy storm
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35004.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-02 14:42:11 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Before
After