? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Jul 2021

Pull Request for Issue #34977 .

Summary of Changes

added isset()

Testing Instructions

see #34977
or export an preset menu

Actual result BEFORE applying this Pull Request

warnings

[30-Jul-2021 13:07:57 UTC] PHP Warning:  Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$class in /shared/httpd/dev4/joomla-cms/administrator/components/com_menus/src/View/Menu/XmlView.php on line 137
[30-Jul-2021 13:08:46 UTC] PHP Warning:  Undefined property: Joomla\CMS\Menu\AdministratorMenuItem::$submenu in /shared/httpd/dev4/joomla-cms/administrator/components/com_menus/src/View/Menu/XmlView.php on line 175
[30-Jul-2021 13:08:51 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in /shared/httpd/dev4/joomla-cms/administrator/components/com_menus/src/View/Menu/XmlView.php on line 175


Expected result AFTER applying this Pull Request

no warnings

avatar alikon alikon - open - 30 Jul 2021
avatar alikon alikon - change - 30 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2021
Category Administration com_menus
avatar alikon alikon - change - 30 Jul 2021
Labels Added: ?
avatar richard67 richard67 - test_item - 30 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 30 Jul 2021

I have tested this item successfully on 15999ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34990.

avatar ReLater ReLater - test_item - 30 Jul 2021 - Tested successfully
avatar ReLater
ReLater - comment - 30 Jul 2021

I have tested this item successfully on 15999ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34990.

avatar richard67 richard67 - change - 30 Jul 2021
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 30 Jul 2021
avatar richard67
richard67 - comment - 30 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34990.

avatar wilsonge wilsonge - change - 23 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-23 18:15:52
Closed_By wilsonge
Labels Added: ? ?
Removed: ?
avatar wilsonge wilsonge - close - 23 Aug 2021
avatar wilsonge wilsonge - merge - 23 Aug 2021

Add a Comment

Login with GitHub to post a comment