[#34985] - [4.0] Fix fatal error while rebuilding update sites
- Fixed in Code Base
- 31 Jul 2021
- Medium
- Build: 4.0-dev
- # 34985
- Diff
- joomdonation:fix_rebuild_updatesite
User tests: Successful: Unsuccessful:
Pull Request for Issue #34984.
Summary of Changes
We need to cast the values to string before bind value to prepared statemement
Testing Instructions
- Set Debug System to enabled in Global Configuration
- Rebuild update sites
- Before patch: You got fatal error
- After patch: update sites rebuilt successfully
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
?
|
||
Adding the release blocker label since rebuilding update sites shall not fail with broken update sites.
@richard67 That direct commit is for adding update sites, I think. This is for rebuild update sites.
@richard67 That direct commit is for adding update sites, I think. This is for rebuild update sites.
Ah, yes, and that was where I observed the error, when installing an extension, and that seems to be solved.
I have tested this item
Easy test. Install some extension (e.g. patchtester). Rebuild update sites and see the error. Apply the patch, rebuild update sites again and see the error has gone and update sites have been correctly rebuilt.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34985.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34985.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34985.
But you have to: Set Debug System to enabled in Global Configuration - then I saw the error before Patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34985.
But you have to: Set Debug System to enabled in Global Configuration - then I saw the error before Patch.
Yes, I have forgotten to mention that in my test result.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34985.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-31 08:06:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@joomdonation I remember now when I had observed the issue a few days ago, @wilsonge had directly fixed it in the 4.0-dev branch with this commit: d78b4e6 .
Was that not sufficient?
And with your fix, will it still need those type casts from that commit?