Feeling Lucky
?
?
[#34973] - Update .eslintrc max length
- Fixed in Code Base
- 30 Jul 2021
- Medium
- Build: 4.0-dev
- # 34973
- Diff
- dgrammatiko:patch-4
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Adjusts the length of the line to 150 chars (same as PHP)
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
brianteeman
- comment
- 29 Jul 2021
My comment on it being reasonable was based on the comment "same as php"
dgrammatiko
- comment
- 29 Jul 2021
| Labels |
Added:
?
|
||
richard67
- comment
- 29 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.
HLeithner
- comment
- 29 Jul 2021
I thought we follow the airbnb style guide why do we need exceptions?
dgrammatiko
- comment
- 29 Jul 2021
I thought we follow the airbnb style guide why do we need exceptions?
We already have some exceptions and also the idea is to adapt the tools to our needs. Right now the tool is dictating something that's not in line with the rest of the project (php files are 150 chr long). In short tools are not rules
Fedik
- comment
- 29 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 29 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34973.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-30 09:15:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 30 Jul 2021
Thanks!
seems reasonable