Feeling Lucky
?
?
[#34965] - [4.0] Replace Factory::getDbo() with $this->getDbo()
- Fixed in Code Base
- 20 Aug 2021
- Medium
- Build: 4.0-dev
- # 34965
- Diff
- joomdonation:com_templates_getdbo
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
General rule is within model classes (for none static methods, of course), we should use $this->getDbo(); instead of Factory::getDbo(); to get database object.
However, there are still few places in our code use Factory::getDbo(); and this PR just fixes that.
Testing Instructions
- Code review
- Or:
- Update your site to this package generated by this PR and make sure it is updated properly (this test the change in UpdateModel)
- Access to System -> Site Templates and make sure it is still being loaded
- Access to Components -> Smart Search -> Filters and make sure it is still being loaded
- Access to System -> Language Overrides, click on Clear Cache button and make sure no error happens.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_joomlaupdate com_languages com_templates |
alikon
- comment
- 30 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34965.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 30 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34965.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-20 11:41:02 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 20 Aug 2021
Thanks!
I have tested this item✅ successfully on 026534e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34965.