? ? Pending

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
28 Jul 2021

Pull Request for Issue # .
#34910

Summary of Changes

Check if there are any other children before removing vendor folder.

Testing Instructions

As described in #34910

Actual result BEFORE applying this Pull Request

Updating or uninstalling one library removes another when both belong to same vendor.

Expected result AFTER applying this Pull Request

Updating or uninstalling one library no longer removes another when both belong to same vendor.

Documentation Changes Required

Check if using library names like these is documented.

mycompany/mylibrary1

mycompany/mylibrary2

avatar BrainforgeUK BrainforgeUK - open - 28 Jul 2021
avatar BrainforgeUK BrainforgeUK - change - 28 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2021
Category Libraries
avatar joomdonation
joomdonation - comment - 28 Jul 2021

@BrainforgeUK Could you please give two sample libraries so that we can use it for testing?

avatar BrainforgeUK
BrainforgeUK - comment - 28 Jul 2021

lib_bftest1.zip
lib_bftest2.zip
lib_bftest3.zip

With J4 RC5
Install the 3 extensions 1,2,3 - installed OK.
Folders .../libraries/brainforgeuk/test[123] exist OK.
Install lib_bftest2 again (do not remove it - pretend its and update).
Admin Extensions Manage page shows all 3 installed.
Folder .../libraries/brainforgeuk/test2 exists, the others have been removed!

With Change
Install the 3 extensions 1,2,3 - installed OK.
Folders .../libraries/brainforgeuk/test[123] exist OK.
Install lib_bftest2 again (do not remove it - pretend its and update).
Admin Extensions Manage page shows all 3 installed.
Folder .../libraries/brainforgeuk/test[123] exist OK.

In admin Extensions Manage page unininstall lib_bftest3 OK, folders for test1 and test2 still exist.
In admin Extensions Manage page unininstall lib_bftest1 OK, folder for test2 still exists.
In admin Extensions Manage page unininstall lib_bftest2 OK, folder brainforgeuk removed.

avatar BrainforgeUK BrainforgeUK - change - 28 Jul 2021
Labels Added: ?
avatar maikol-ortigueira maikol-ortigueira - test_item - 30 Jul 2021 - Tested successfully
avatar maikol-ortigueira
maikol-ortigueira - comment - 30 Jul 2021

I have tested this item successfully on 6b2c94b

I have tested this issue successfully, and for this I have made use of the files you provide.

PHP version : 7.4
Joomla Version: 4.0.0-rc5
OS: Ubuntu 20.04.2 LTS

Thank you!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar pabloarias
pabloarias - comment - 30 Jul 2021

Tested with Devilbox and library packages provided.

PHP 7.4.20
Joomla! 4.0.0-rc6-dev

Thank very much!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar pabloarias pabloarias - test_item - 30 Jul 2021 - Tested successfully
avatar pabloarias
pabloarias - comment - 30 Jul 2021

I have tested this item successfully on 6b2c94b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar alikon alikon - change - 30 Jul 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar alikon
alikon - comment - 30 Jul 2021

happy to see yet another one Devilbox https://github.com/cytopia/devilbox/ user

avatar richard67
richard67 - comment - 30 Jul 2021

@BrainforgeUK Could you implement @joomdonation ' suggestion above - see #34954 (comment) - and remove the empty arrays for the last 2 parameters so the defaults are used? I will then help to get testers again. Thanks in advance.

avatar alikon alikon - change - 30 Jul 2021
Status Ready to Commit Pending
avatar alikon
alikon - comment - 30 Jul 2021

back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar BrainforgeUK BrainforgeUK - change - 30 Jul 2021
Labels Added: ?
avatar BrainforgeUK
BrainforgeUK - comment - 30 Jul 2021

Removed the empty arrays, as requested,

avatar richard67
richard67 - comment - 30 Jul 2021

Thanks

avatar richard67
richard67 - comment - 30 Jul 2021

@maikol-ortigueira @pabloarias Could you test again? There has been made a change. Thanks in advance.

avatar richard67
richard67 - comment - 31 Jul 2021

@BrainforgeUK Sorry I have to bother you again. My mistake, I promose it's the last time. Could you also remove the optional two boolean parameters which now are the last two, so only $folders = Folder::folders(JPATH_PLATFORM . '/' . $elementParts[0], '.'); remains? Thanks in advance.

@joomdonation is right, we don't need to use absolute path here, so the last 2 could be "false, false" and so equal to the defaults instead of "false, true".

avatar BrainforgeUK BrainforgeUK - change - 31 Jul 2021
Labels Removed: ?
avatar richard67
richard67 - comment - 31 Jul 2021

@BrainforgeUK Thanks a lot, very appreciated. Will prepare to test now.

avatar BrainforgeUK
BrainforgeUK - comment - 31 Jul 2021

Also removed the filter parameter as the default is the same.
Ok challenging me on this ... spend to much time on DIY!
Maybe might be able to usefully contribute again another time.

avatar richard67 richard67 - test_item - 31 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 31 Jul 2021

I have tested this item successfully on 19ba82c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar joomdonation joomdonation - test_item - 31 Jul 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 31 Jul 2021

I have tested this item successfully on 19ba82c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar richard67 richard67 - change - 31 Jul 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 31 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34954.

avatar richard67
richard67 - comment - 31 Jul 2021

@wilsonge Because it's a fix for the installer, I'd like to have that in 4.0, so I've set the 4.0 milestone. Feel free to change if not ok.

avatar wilsonge wilsonge - change - 2 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-02 09:35:37
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Aug 2021
avatar wilsonge wilsonge - merge - 2 Aug 2021
avatar wilsonge
wilsonge - comment - 2 Aug 2021

Thanks!

Add a Comment

Login with GitHub to post a comment