User tests: Successful: 2 joomdonation, richard67 Unsuccessful: 0
Pull Request for Issue # .
#34910
Check if there are any other children before removing vendor folder.
As described in #34910
Updating or uninstalling one library removes another when both belong to same vendor.
Updating or uninstalling one library no longer removes another when both belong to same vendor.
Check if using library names like these is documented.
mycompany/mylibrary1
mycompany/mylibrary2
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
lib_bftest1.zip
lib_bftest2.zip
lib_bftest3.zip
With J4 RC5
Install the 3 extensions 1,2,3 - installed OK.
Folders .../libraries/brainforgeuk/test[123] exist OK.
Install lib_bftest2 again (do not remove it - pretend its and update).
Admin Extensions Manage page shows all 3 installed.
Folder .../libraries/brainforgeuk/test2 exists, the others have been removed!
With Change
Install the 3 extensions 1,2,3 - installed OK.
Folders .../libraries/brainforgeuk/test[123] exist OK.
Install lib_bftest2 again (do not remove it - pretend its and update).
Admin Extensions Manage page shows all 3 installed.
Folder .../libraries/brainforgeuk/test[123] exist OK.
In admin Extensions Manage page unininstall lib_bftest3 OK, folders for test1 and test2 still exist.
In admin Extensions Manage page unininstall lib_bftest1 OK, folder for test2 still exists.
In admin Extensions Manage page unininstall lib_bftest2 OK, folder brainforgeuk removed.
Labels |
Added:
?
|
I have tested this item
I have tested this issue successfully, and for this I have made use of the files you provide.
PHP version : 7.4
Joomla Version: 4.0.0-rc5
OS: Ubuntu 20.04.2 LTS
Thank you!!
Tested with Devilbox and library packages provided.
PHP 7.4.20
Joomla! 4.0.0-rc6-dev
Thank very much!
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
happy to see yet another one Devilbox https://github.com/cytopia/devilbox/ user
@BrainforgeUK Could you implement @joomdonation ' suggestion above - see #34954 (comment) - and remove the empty arrays for the last 2 parameters so the defaults are used? I will then help to get testers again. Thanks in advance.
Status | Ready to Commit | ⇒ | Pending |
back to pending
Labels |
Added:
?
|
Removed the empty arrays, as requested,
Thanks
@maikol-ortigueira @pabloarias Could you test again? There has been made a change. Thanks in advance.
@BrainforgeUK Sorry I have to bother you again. My mistake, I promose it's the last time. Could you also remove the optional two boolean parameters which now are the last two, so only $folders = Folder::folders(JPATH_PLATFORM . '/' . $elementParts[0], '.');
remains? Thanks in advance.
@joomdonation is right, we don't need to use absolute path here, so the last 2 could be "false, false" and so equal to the defaults instead of "false, true".
Labels |
Removed:
?
|
@BrainforgeUK Thanks a lot, very appreciated. Will prepare to test now.
Also removed the filter parameter as the default is the same.
Ok challenging me on this ... spend to much time on DIY!
Maybe might be able to usefully contribute again another time.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-02 09:35:37 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
@BrainforgeUK Could you please give two sample libraries so that we can use it for testing?