[#34942] - [4.0] Atum: Prevent warping custom logos in header
- Fixed in Code Base
- 27 Jul 2021
- Medium
- Build: 4.0-dev
- # 34942
- Diff
- crystalenka:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #34355 .
Summary of Changes
By adding a few lines of CSS, we are able to ensure that custom logos in the admin template are not warped even if they don't fit the exact dimensions of the space available.
Testing Instructions
- Go to
System > Templates > Administrator Template Styles. - Open a style of your choice and navigate to
Image Settings. - Scroll down to "Brand Large". Upload an image with dimensions other than 30x150 pixels.
- Scroll down to "Brand Small". Upload an image that is not square aspect ratio.
- Save and close.
Actual result BEFORE applying this Pull Request
"Brand Large" and "Brand Small" images are stretched and warped to fit specific pixel dimensions regardless of their original proportions or size.
Expected result AFTER applying this Pull Request
"Brand Large" and "Brand Small" display with the correct aspect ratio, within the space available.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-27 20:47:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Nice! that was quick.
Thankyou <3 And good to see you around again - even if just for a quick PR!
It's a pleasure! I'm always around, just not always with the energy to participate much :) I will try to do more as I can.
I was going to ask if this needed to be done for the login logo as well - but that image seems to work fine without it - weird. Not sure I will ever truly get css
I was going to ask if this needed to be done for the login logo as well - but that image seems to work fine without it - weird. Not sure I will ever truly get css
I checked; the login logo does not have hard-coded dimensions like the header logos. It has a max-height, and that's it. (Probably, it should also have a max-width...but that's another PR for another day.) Max-height and max-width are an alternative way of solving this same problem.
Merged too quickly. @richard67 is correct it needs adjusting for RTL. Will do a PR now
Merged too quickly. @richard67 is correct it needs adjusting for RTL. Will do a PR now
Thanks Brian!
Thankyou <3 And good to see you around again - even if just for a quick PR!