NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar pinak3748
pinak3748
27 Jul 2021

Pull Request for Issue # .

Summary of Changes

made changes in vertical alignment of table rows.

Testing Instructions

run npm ci in order to compile new SCSS changes

Actual result BEFORE applying this Pull Request

pinak_cms

Expected result AFTER applying this Pull Request

Screenshot 2021-07-27 113950

avatar pinak3748 pinak3748 - open - 27 Jul 2021
avatar pinak3748 pinak3748 - change - 27 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2021
Category Administration Templates (admin) NPM Change
avatar brianteeman
brianteeman - comment - 27 Jul 2021

This is not good. If you have a table with cells that have different heights you end up with a very messy row. For readability its much better for everything to be in a line

Before - good

image

After - not so good

image

avatar pinak3748
pinak3748 - comment - 27 Jul 2021

yaa you are right I didn't though about it.

avatar pinak3748 pinak3748 - change - 27 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-27 07:30:09
Closed_By pinak3748
Labels Added: NPM Resource Changed ?
avatar pinak3748 pinak3748 - close - 27 Jul 2021
avatar brianteeman
brianteeman - comment - 27 Jul 2021

No problem

Add a Comment

Login with GitHub to post a comment