? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
26 Jul 2021

Pull Request for Issue #34908

Summary of Changes

I have removed messagequeue logger from bootstrap, and added changes from #34912 by @brianteeman

Testing Instructions

Please follow #34908

Documentation Changes Required

Logging of jerror can be configured in global configuration:
Screenshot_2021-07-26_15-33-40

avatar Fedik Fedik - open - 26 Jul 2021
avatar Fedik Fedik - change - 26 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2021
Category Libraries
avatar wilsonge
wilsonge - comment - 26 Jul 2021

I think this change is too much. That's a too big a b/c break at this stage. I think @brianteeman 's PR is the right lines. We probably just need a general log file to be created. There are other system level logs we throw in various places for the category. Obviously I understand jerror is not good.

avatar Fedik
Fedik - comment - 26 Jul 2021

That's a too big a b/c break at this stage.

I think no one will cry for this kind of logging (with use of an alert),
anyway it is useless for an average User :)

As you decide.

@brianteeman PR also okay, but then we need another category, that not a jerror and not update.
Or can just remove the log from that place, in general

avatar wilsonge
wilsonge - comment - 26 Jul 2021

I think no one will cry for this kind of logging (with use of an alert),
anyway it is useless for an average User :)

I agree but I know several extension take advantage of it. It's just not worth the pain.

@brianteeman PR also okay, but then we need another category, that not a jerror and not update.

agreed

Or can just remove the log from that place, in general

Probably worth keeping in case of any very weird edge cases.

avatar Fedik Fedik - change - 27 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-27 07:05:13
Closed_By Fedik
Labels Added: ?
avatar Fedik Fedik - close - 27 Jul 2021

Add a Comment

Login with GitHub to post a comment