User tests: Successful: Unsuccessful:
Pull Request for Issue #34908 .
When you update from 3.10 you immediately get an error message The template for this display is not available.
On an update this is a false positive.
This PR changes it from a visible message to a log
testing is time consuming for such a minor change and can probably be accepted by code review
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
@brianteeman I've just tested updating a clean, current 3.10-dev to the update package built by drone for this PR.
There is still an alert, only it has changed from red to yellow.
No idea where that comes from. Either it is issued at another place again, or the log is somehow used for alerts, too.
The 'jerror' last parameter makes it go into an alert. Maybe use 'error', or if that works 'Update'? In the latter case it should go then into the Joomla Update log.
This PR changes it from a visible message to a log
it does not change, all jerror
logs goes to message
joomla-cms/libraries/bootstrap.php
Lines 77 to 82 in ed9d8e8
Updated to generate a build so I can test "Update" which is how its used elsewhere
And changing to Update
is not allowed ;)
Because AdministratorApplication::getTemplate()
is general method, so error is joomla runtime error, not specificity "update" error
The same error we have when you trying to load a non existing user with JUser::getInstance(<random id>)
ok I give up
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-26 12:00:51 |
Closed_By | ⇒ | brianteeman |
ok I give up
that was to fast :)
I would remove this code
joomla-cms/libraries/bootstrap.php
Lines 77 to 82 in ed9d8e8
But not sure if it allowed :)
Status | Closed | ⇒ | New |
Closed_Date | 2021-07-26 12:00:51 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Pending |
Category | Libraries | ⇒ | Administration com_joomlaupdate Libraries |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-26 17:13:05 |
Closed_By | ⇒ | brianteeman |
Can be easily tested by using the update package or custom update URL build by drone.