? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jul 2021

Pull Request for Issue #34908 .

When you update from 3.10 you immediately get an error message The template for this display is not available.

On an update this is a false positive.

This PR changes it from a visible message to a log

#34908 (comment)

testing is time consuming for such a minor change and can probably be accepted by code review

avatar brianteeman brianteeman - open - 26 Jul 2021
avatar brianteeman brianteeman - change - 26 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2021
Category Libraries
e52931c 26 Jul 2021 avatar brianteeman cs
avatar brianteeman brianteeman - change - 26 Jul 2021
Labels Added: ?
avatar richard67
richard67 - comment - 26 Jul 2021

testing is time consuming for such a minor change and can probably be accepted by code review

Can be easily tested by using the update package or custom update URL build by drone.

avatar richard67
richard67 - comment - 26 Jul 2021

@brianteeman I've just tested updating a clean, current 3.10-dev to the update package built by drone for this PR.

There is still an alert, only it has changed from red to yellow.

2021-07-26_test-pr-34912_1

No idea where that comes from. Either it is issued at another place again, or the log is somehow used for alerts, too.

avatar richard67
richard67 - comment - 26 Jul 2021

The 'jerror' last parameter makes it go into an alert. Maybe use 'error', or if that works 'Update'? In the latter case it should go then into the Joomla Update log.

avatar Fedik
Fedik - comment - 26 Jul 2021

This PR changes it from a visible message to a log

it does not change, all jerror logs goes to message

// Set up the message queue logger for web requests
if (array_key_exists('REQUEST_METHOD', $_SERVER))
{
JLog::addLogger(['logger' => 'messagequeue'], JLog::ALL, ['jerror']);
}

avatar brianteeman
brianteeman - comment - 26 Jul 2021

Updated to generate a build so I can test "Update" which is how its used elsewhere

avatar Fedik
Fedik - comment - 26 Jul 2021

And changing to Update is not allowed ;)
Because AdministratorApplication::getTemplate() is general method, so error is joomla runtime error, not specificity "update" error

The same error we have when you trying to load a non existing user with JUser::getInstance(<random id>)

avatar brianteeman
brianteeman - comment - 26 Jul 2021

ok I give up

avatar brianteeman brianteeman - close - 26 Jul 2021
avatar brianteeman brianteeman - change - 26 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-26 12:00:51
Closed_By brianteeman
avatar Fedik
Fedik - comment - 26 Jul 2021

ok I give up

that was to fast :)

I would remove this code

// Set up the message queue logger for web requests
if (array_key_exists('REQUEST_METHOD', $_SERVER))
{
JLog::addLogger(['logger' => 'messagequeue'], JLog::ALL, ['jerror']);
}

And then make the changes you made here.

But not sure if it allowed :)

avatar brianteeman brianteeman - change - 26 Jul 2021
Status Closed New
Closed_Date 2021-07-26 12:00:51
Closed_By brianteeman
avatar brianteeman brianteeman - change - 26 Jul 2021
Status New Pending
avatar brianteeman brianteeman - reopen - 26 Jul 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2021
Category Libraries Administration com_joomlaupdate Libraries
avatar brianteeman brianteeman - change - 26 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-26 17:13:05
Closed_By brianteeman
avatar brianteeman brianteeman - close - 26 Jul 2021

Add a Comment

Login with GitHub to post a comment