[#34905] - [4.0]Translate menus
- Fixed in Code Base
- 26 Jul 2021
- Medium
- Build: 4.0-dev
- # 34905
- Diff
- brianteeman:transmenu
User tests: Successful: Unsuccessful:
On a site with multiple admin languages you would expect that the name of the menu could be translated.
Test instructions
Create an admin menu and give it a title such as JADMINISTRATOR
Create a site menu and give it a title such as JSITE
Expected behaviour
The names of both menus are translated
Actual behaviour
Only the name of the admin menu is translated
Solution
I have no idea why but there is an extra space at the end of $item->title so the string being passed through JText is "JSITE " which obviously doesn't match. I have no idea why there is not an extra space for the admin menu
This PR trims $item->title so that now the site menu name is also translated.
No idea if this is a hack/bandage or the correct solution but its been bugging me for hours and I can't find the space
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
Will check in the morning but looks like it could be
On Mon, 26 Jul 2021, 00:37 Richard Fath, @.***> wrote:
@brianteeman https://github.com/brianteeman Can it be that the space
comes from here?
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_menus/presets/default.xml#L147—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34905 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4P4NT4YL5HUASD3ZWBGDTZSN5DANCNFSM5A67QUFQ
.
Thanks @richard67 well spotted.
@brianteeman I know it's not related to this PR. but as you are touching that file, maybe you could fix the typo in the comment here, too?
"The repeated elements are place" should be changed to "The repeated elements are placed".
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-26 18:28:21 |
| Closed_By | ⇒ | wilsonge |
Thanks!
thx
@brianteeman Can it be that the space comes from here? https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_menus/presets/default.xml#L147