[#34900] - [4.0] Render the full information in the installer
- Fixed in Code Base
- 16 Aug 2021
- Medium
- Build: 4.0-dev
- # 34900
- Diff
- wilsonge:fix/installer-description
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #34873 .
Summary of Changes
Partial fix for issue mentioned - Render fields in the installer using the renderField method. This renders a description stating the number of minimum characters that had been hidden until now. Eventually this should be replaced by javascript stating the correct number of figures. But it's a start.
As we now render the full control group - we override the CSS to not add extra paddings (it's honestly barely noticeable on my Laptop 13" screen - but just covers bases)
Testing Instructions
Check that a description appears on the password field for the admin user stating the minimum length is 12 characters
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
As it cannot be configured there will be no need for any js
The JS can block the submission of the form to prevent you going to the next step. A note is good - although in a way it already exists with the password strength meter - this just makes it more explicit. Active communication + prevention is better (in my opinion)
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
I have tested this item
First of all
Hey, good and quick solution.
That's how I tested it
I installed the project from your branch and then continued the installation process until I entered the password. Among other things, I changed the window to different sizes.
Result
In general, everything worked and there were no problems.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
| Status | Ready to Commit | ⇒ | Pending |
Sorry, mistake .. did not want to set RTC, wanted to set test result.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
@scout507 @socke300 Could you repeat your test and check if the styling issue mentioned in @Quy 's comment #34900 (comment) have been solved? You have to (temporarily) select something else than the default for the "Connection Encryption" in database settings to see the effect. Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34900.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-16 22:26:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? ? |
||
As it cannot be configured there will be no need for any js