User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Ignore files and folders of the eos310 plugin in build/deleted_file_check.php because files and folders of this plugin will be deleted when uninstalling it, which is implemented with PR #34895 .
In general we handle the repeatable field plugin in the same way.
It needs a git clone of the CMS repository or your fork of it. A normal installation based e.g. on nightly build will not be enough because the test concerns the "build" folder, which is not included in the installation packages.
For the same reason, this PR cannot be applied with patchtester.
Because we don't have a 3.10 nightly build yet which includes the 3.10 EOS plugin, it needs to create a 3.10 full installation package based on the current 3.10-dev branch.
To do that, checkout the 3.10-dev branch. If necessary, update it to latest 3.10-dev of the upstream repository here.
Then open a command window and change directory to the root folder of your git clone.
Now enter following command and wait until it has finished:
php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2
After that, you can find the package Joomla_3.10.0-alpha10-dev-Development-Full_Package.zip
in the build/tmp/packages
folder.
Save the package somewhere outside of the root folder of your git clone.
If the package build doesn't work for you for some reason, you can download the package from here: https://test5.richard-fath.de/Joomla_3.10.0-alpha10-dev-Development-Full_Package.zip
Now checkout the 4.0-dev branch. If necessary, update it to latest 4.0-dev of the upstream repository here.
Now you can build again a package like described above and find the result Joomla_4.0.0-rc5-dev-Development-Full_Package.zip
again in folder build/tmp/packages
, or download the latest 4.0 nightly build from here: https://developer.joomla.org/nightlies/Joomla_4.0.0-rc5-dev-Development-Full_Package.zip .
In both cases save the package somewhere outside of the root folder of your git clone.
Now, still being on the 4.0-dev branch, unpack the previously built or downloaded 3.10 and 4.0 packages to the build
folder into a folder with the same name as the package, so you have following folder relative to the root:
Now you are ready for the test.
On a clean, current 4.0-dev branch prepared as described above, open a command window (e.g. Windows CMD on Windows or bash on Linux) in the root folder of your git clone.
Change directory to the build
folder:
cd build
php ./deleted_file_check.php --from=./Joomla_3.10.0-alpha10-dev-Development-Full_Package --to=./Joomla_4.0.0-rc5-dev-Development-Full_Package
Result: Three files have been created:
mv deleted_files.txt deleted_files_1.txt
mv deleted_folders.txt deleted_folders_1.txt
mv renamed_files.txt renamed_files_1.txt
Apply the patch of this PR.
Repeat step 3.
Compare the files generated the previous step 6 with those created in step 3.
Result: The screenshots below show on the left hand side of the comparison the file created in step 6 with this PR applied and on the right hand side the one created in step 3 without this PR applied.
The files and folders of the 3.10 EOS plugin will be included in the lists of files and folders to be deleted on update.
When updating script.php based on these lists and then updating a clean, current 3.10-dev branch to a 4.0 update package with these changes and the changes from PR #34895 , the update will end with following error:
The files and folders of the 3.10 EOS plugin will not be included in the lists of files and folders to be deleted on update.
They will be deleted when the plugin is uninstalled after PR #34895 has been merged.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Repository |
Title |
|
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-25 20:44:26 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks.
Thanks!