? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 Jul 2021

Pull Request for Issue # .

Summary of Changes

Ignore files and folders of the eos310 plugin in build/deleted_file_check.php because files and folders of this plugin will be deleted when uninstalling it, which is implemented with PR #34895 .

In general we handle the repeatable field plugin in the same way.

Testing Instructions

Requirement

It needs a git clone of the CMS repository or your fork of it. A normal installation based e.g. on nightly build will not be enough because the test concerns the "build" folder, which is not included in the installation packages.

For the same reason, this PR cannot be applied with patchtester.

Preparation

Because we don't have a 3.10 nightly build yet which includes the 3.10 EOS plugin, it needs to create a 3.10 full installation package based on the current 3.10-dev branch.

To do that, checkout the 3.10-dev branch. If necessary, update it to latest 3.10-dev of the upstream repository here.

Then open a command window and change directory to the root folder of your git clone.

Now enter following command and wait until it has finished:

php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2

After that, you can find the package Joomla_3.10.0-alpha10-dev-Development-Full_Package.zip in the build/tmp/packages folder.

Save the package somewhere outside of the root folder of your git clone.

If the package build doesn't work for you for some reason, you can download the package from here: https://test5.richard-fath.de/Joomla_3.10.0-alpha10-dev-Development-Full_Package.zip

Now checkout the 4.0-dev branch. If necessary, update it to latest 4.0-dev of the upstream repository here.

Now you can build again a package like described above and find the result Joomla_4.0.0-rc5-dev-Development-Full_Package.zip again in folder build/tmp/packages, or download the latest 4.0 nightly build from here: https://developer.joomla.org/nightlies/Joomla_4.0.0-rc5-dev-Development-Full_Package.zip .

In both cases save the package somewhere outside of the root folder of your git clone.

Now, still being on the 4.0-dev branch, unpack the previously built or downloaded 3.10 and 4.0 packages to the build folder into a folder with the same name as the package, so you have following folder relative to the root:

  • build/Joomla_3.10.0-alpha10-dev-Development-Full_Package
  • build/Joomla_4.0.0-rc5-dev-Development-Full_Package

Now you are ready for the test.

Test procedure

  1. On a clean, current 4.0-dev branch prepared as described above, open a command window (e.g. Windows CMD on Windows or bash on Linux) in the root folder of your git clone.

  2. Change directory to the build folder:

cd build
  1. Enter following command and wait until it has finished:
php ./deleted_file_check.php --from=./Joomla_3.10.0-alpha10-dev-Development-Full_Package --to=./Joomla_4.0.0-rc5-dev-Development-Full_Package

Result: Three files have been created:

  • deleted_files.txt
  • deleted_folders.txt
  • renamed_files.txt
  1. Rename the three generated files
mv deleted_files.txt deleted_files_1.txt
mv deleted_folders.txt deleted_folders_1.txt
mv renamed_files.txt renamed_files_1.txt
  1. Apply the patch of this PR.

  2. Repeat step 3.

  3. Compare the files generated the previous step 6 with those created in step 3.

Result: The screenshots below show on the left hand side of the comparison the file created in step 6 with this PR applied and on the right hand side the one created in step 3 without this PR applied.

  • deleted_files.txt shows the following three differences

2021-07-25_pr-34898_1

2021-07-25_pr-34898_2

2021-07-25_pr-34898_3

  • deleted_folders.txt shows the following two differences

2021-07-25_pr-34898_4

2021-07-25_pr-34898_5

  • renamed_files.txt doesn't show any difference

Actual result BEFORE applying this Pull Request

The files and folders of the 3.10 EOS plugin will be included in the lists of files and folders to be deleted on update.

When updating script.php based on these lists and then updating a clean, current 3.10-dev branch to a 4.0 update package with these changes and the changes from PR #34895 , the update will end with following error:

2021-07-25_eos-uninstall-error

Expected result AFTER applying this Pull Request

The files and folders of the 3.10 EOS plugin will not be included in the lists of files and folders to be deleted on update.

They will be deleted when the plugin is uninstalled after PR #34895 has been merged.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2021
Category Repository
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
Title
[4.0] [WiP] Ignore stuff from eos310 plugin in build/deleted_file_check.php
[4.0] Ignore stuff from eos310 plugin in build/deleted_file_check.php
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
Title
[4.0] Ignore stuff from eos310 plugin in build/deleted_file_check.php
[4.0] Ignore files and folders of the eos310 plugin in build/deleted_file_check.php
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar richard67 richard67 - change - 25 Jul 2021
The description was changed
avatar richard67 richard67 - edited - 25 Jul 2021
avatar wilsonge wilsonge - change - 25 Jul 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-25 20:44:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Jul 2021
avatar wilsonge wilsonge - merge - 25 Jul 2021
avatar wilsonge
wilsonge - comment - 25 Jul 2021

Thanks!

avatar richard67
richard67 - comment - 25 Jul 2021

Thanks.

Add a Comment

Login with GitHub to post a comment