Feeling Lucky
?
?
[#34877] - [4.0] mail templates title
- Fixed in Code Base
- 23 Jul 2021
- Medium
- Build: 4.0-dev
- # 34877
- Diff
- brianteeman:parenthesis
User tests: Successful: Unsuccessful:
This PR addresses several issues.
- The technical name of the mail template is moved out of the H1 and onto its own line. Its not part of the title and is obviously non-translatable and also not screen reader friendly so it is moved to a new line
- Hard coding parentheses in the html is a problem as some languages use different characters to the brace. We can remove them completely now that its on its own line.
No language strings are harmed in the mergin of this PR.
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
richard67
- comment
- 23 Jul 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34877.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 23 Jul 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34877.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-23 10:52:08 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
chmst
- comment
- 23 Jul 2021
Thanks!
brianteeman
- comment
- 23 Jul 2021
Thanks
I have tested this item✅ successfully on ca55fe9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34877.