NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Jul 2021

This PR fixes the alignment of items in the actions dropdown menu using logical css properties. There is no visible change in LTR

LTR Before/After

image

RTL Before

image

RTL After

image

avatar brianteeman brianteeman - open - 21 Jul 2021
avatar brianteeman brianteeman - change - 21 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2021
Category Administration Templates (admin) NPM Change
avatar wilsonge wilsonge - close - 22 Jul 2021
avatar wilsonge wilsonge - merge - 22 Jul 2021
avatar wilsonge wilsonge - change - 22 Jul 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-22 08:51:44
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge
wilsonge - comment - 22 Jul 2021

Thanks!

avatar richard67
richard67 - comment - 22 Jul 2021

@wilsonge We have scss code style errors reported for this merge in the 4.0-dev branch, see https://ci.joomla.org/joomla/joomla-cms/45991/1/20 :

administrator/templates/atum/scss/vendor/bootstrap/_dropdown.scss
20:3  ✖  Expected "text-align" to come before "border-bottom"   order/properties-order
avatar brianteeman
brianteeman - comment - 22 Jul 2021

thanks for merging - I will do another pr to fix my codestyle error

avatar brianteeman
brianteeman - comment - 22 Jul 2021

never mind I see @wilsonge did it already

avatar richard67
richard67 - comment - 22 Jul 2021

thanks for merging - I will do another pr to fix my codestyle error

@brianteeman George has fixed it already in the 4.0-dev branch.

Add a Comment

Login with GitHub to post a comment