Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34856] - [4.0] modal buttons rtl

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Jul 2021

This PR fixes a bug with the margin when in rtl that can be seeon in com_templates when you open the modal to create a new file. By switching to logical css properties for the margin it now works correctly in RTL and LTR without any additional classes.

Before

image

After

image

avatar brianteeman brianteeman - open - 21 Jul 2021
avatar brianteeman brianteeman - change - 21 Jul 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2021
Category ⇒ Administration Templates (admin) NPM Change
avatar richard67 richard67 - test_item - 21 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 21 Jul 2021

I have tested this item ✅ successfully on cbb1454

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34856.

avatar wilsonge wilsonge - change - 21 Jul 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-07-21 21:37:36
Closed_By ⇒ wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 21 Jul 2021
avatar wilsonge wilsonge - merge - 21 Jul 2021
avatar wilsonge
wilsonge - comment - 21 Jul 2021

Thanks!

avatar brianteeman
brianteeman - comment - 21 Jul 2021

thanks

Add a Comment

Login with GitHub to post a comment