Feeling Lucky
NPM Resource Changed
?
[#34853] - [4.0] unused legacy rtl scss
- Fixed in Code Base
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34853
- Diff
- brianteeman:switcher
User tests: Successful: Unsuccessful:
As far as I can tell none of the classes removed here are actually used.
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
brianteeman
- comment
- 21 Jul 2021
Would be good if someone could find out where its being used as I couldnt find it.
wilsonge
- comment
- 21 Jul 2021
I have to say I don't see it either. But in this case we should remove the LTR SCSS too rather than it being some halfway house
brianteeman
- comment
- 21 Jul 2021
will update the pr
| Labels |
Added:
NPM Resource Changed
?
|
||
brianteeman
- comment
- 21 Jul 2021
Updated as requested
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 21:54:49 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 21 Jul 2021
Thanks!
brianteeman
- comment
- 21 Jul 2021
thanks
On code review alone I think the published and unpublished might be being used. Agreed that the rest is not