[#34849] - [4.0] Cassiopeia - Remove 'debug' from grid area and add min-height to 'body'
- Fixed in Code Base
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34849
- Diff
- drmenzelit:4.0-dev-grid
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Removed the grid area debug
Added min-height to body
Testing Instructions
Create a page with short content.
Test with debug enabled.
Actual result BEFORE applying this Pull Request
If the css grid contains an area for debug the template adds a gap under the footer.
In short pages the footer shows middle on the page instead of at the bottom, because the body has no height defined:
Expected result AFTER applying this Pull Request
No gap under the footer, footer at the bottom of the page no matter the length of the content, debug is displayed correctly without specifically defined grid area
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
Finally I got it. Thanks for assistance @chmst
(Tried on another page with the same article as above 'love')
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 08:00:12 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on 16ecf62
Thanks! It is just what I need for my new project.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.