[#34845] - [4.0] change %s to %d
- Fixed in Code Base
- 23 Aug 2021
- Medium
- Build: 4.0-dev
- # 34845
- Diff
- brianteeman:finaltemp
User tests: Successful: Unsuccessful:
IF you're going to do it then do it right ;) #34844
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34845.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34845.
Apparently, you also need it here: https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/language/en-GB/joomla.ini#L295 (+ similarly for en-US).
@brianteeman Can you explain how such a replacement is explained? Thanks.
Apparently, you also need it here: https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/language/en-GB/joomla.ini#L295 (+ similarly for en-US).
Yes every %s what is a number should be changed to %d but I only fixed the reported string by the translator. If someone is motivated to check all language file for wrong translations it would be really appreciated.
. If someone is motivated to check all language file for wrong translations it would be really appreciated.
I was and that is what this PR is. I just forgot to check the installation folder which I will do now
| Labels |
Added:
?
?
?
|
||
| Category | Administration Language & Strings | ⇒ | Administration Language & Strings Installation |
. If someone is motivated to check all language file for wrong translations it would be really appreciated.
I was and that is what this PR is. I just forgot to check the installation folder which I will do now
Oh I mixed up the PR thought that's my second pr, good then I hope you already found everything.
| Labels |
Added:
?
Removed: ? |
||
. If someone is motivated to check all language file for wrong translations it would be really appreciated.
I was and that is what this PR is. I just forgot to check the installation folder which I will do now
Oh I mixed up the PR thought that's my second pr, good then I hope you already found everything.
No problem. Can't guarantee I found them all but definitely found the majority
@brianteeman if you could fix the conflicts, we can merge it.
| Labels |
Added:
?
Language Change
?
Removed: ? ? ? |
||
conflicts resolved
Sry didn't See it earlier, can you please remove the US translation changes. This would make problems with the deployment script
| Labels |
Added:
?
?
Removed: ? ? |
||
| Labels |
Added:
?
?
Removed: ? ? |
||
@HLeithner done
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 09:22:52 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
Removed: ? ? |
||
thx
Thanks
I have tested this item✅ successfully on f79b3ce
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34845.