[#34839] - [4.0] admin logo rtl margin
- Fixed in Code Base
- 19 Jul 2021
- Medium
- Build: 4.0-dev
- # 34839
- Diff
- brianteeman:logoright
User tests: Successful: Unsuccessful:
The margins on the logo and sidebar were changed in LTR but the RTL override was not updated. As its no longer needed this PR removes the override.
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
can't test PRs with RTL. E.g. persian language and other are not released. https://downloads.joomla.org/language-packs/translations-joomla4
Tried also changing in index.php:
`// Enable assets
$wa->usePreset('template.atum.' . ($this->direction === 'rtl' ? 'rtl' : 'rtl'))
->useStyle('template.active.language')
->useStyle('template.user')
->addInlineStyle(':root {
--hue: ' . $matches[1] . ';
--template-bg-light: ' . $this->params->get('bg-light', '#f0f4fb') . ';
--template-text-dark: ' . $this->params->get('text-dark', '#495057') . ';
--template-text-light: ' . $this->params->get('text-light', '#ffffff') . ';
--template-link-color: ' . $this->params->get('link-color', '#2a69b8') . ';
--template-special-color: ' . $this->params->get('special-color', '#001B4C') . ';
}');
// Override 'template.active' asset to set correct ltr/rtl dependency
$wa->registerStyle('template.active', '', [], [], ['template.atum.' . ($this->direction === 'rtl' ? 'rtl' : 'rtl')]);`
Go to \administrator\language\en-GB\langmetadata.xml
Line 16: <rtl>0</rtl>
Change 0 to 1.
I have tested this item
Thank you @Quy
Not so easy to look from RTL :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34839.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34839.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-19 21:37:05 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
thx
I have tested this item✅ successfully on 50042a5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34839.