? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jul 2021

It is not necessary to have separate classes for rtl and ltr to put a .2em gap between the text and the icon. margin-inline-end works in both directions

This is an scss change

There is no visible change in either LTR or RTL after this PR

image

avatar brianteeman brianteeman - open - 18 Jul 2021
avatar brianteeman brianteeman - change - 18 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2021
Category Front End Templates (site) NPM Change
avatar Quy Quy - test_item - 19 Jul 2021 - Tested successfully
avatar Quy
Quy - comment - 19 Jul 2021

I have tested this item successfully on 45015a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34829.

avatar RickR2H RickR2H - test_item - 20 Jul 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 20 Jul 2021

I have tested this item successfully on 45015a8

Worked as described!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34829.

avatar Quy Quy - change - 20 Jul 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 20 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34829.

avatar richard67 richard67 - change - 21 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-21 10:16:24
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 21 Jul 2021
avatar richard67 richard67 - merge - 21 Jul 2021
avatar richard67
richard67 - comment - 21 Jul 2021

Thanks

avatar brianteeman
brianteeman - comment - 21 Jul 2021

thx

Add a Comment

Login with GitHub to post a comment