[#34817] - [4.0] webauthn rtl
- Fixed in Code Base
- 21 Jul 2021
- Medium
- Build: 4.0-dev
- # 34817
- Diff
- brianteeman:webauth
User tests: Successful: Unsuccessful:
It is not necessary to have separate classes for rtl and ltr to put a 2px gap between the text and the icon. margin-inline-end works in both directions
This is an scss change
The webauthn stuff will only display if your site is https
There is no visible change in either LTR or RTL after this PR
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34817.
If accepted there are a lot of other places where we should change to logical css properties
@brianteeman We have to check browser support for each. Margin-inline-start and -end are widely supported (except of IE which doesn't matter here), but with other logical css properties it might be different.
i'm not completely incompetent. i only used logical properties that are supported.
i'm not completely incompetent. i only used logical properties that are supported.
@brianteeman Sure. But for proper testing it needs to verify that, I think. Anyway, I did check that here and for the other PR's and it seems all is ok.
it had better be ok as they are already being used ;)
would have been great to use float:inline-start but that one is only firefox
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) NPM Change | ⇒ | Administration Templates (admin) NPM Change Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34817.
any reason this isnt rtc and/or merged yet?
I keep trying to fix it again
any reason this isnt rtc and/or merged yet?
I keep trying to fix it again
@brianteeman After my test you had added the change for the frontend. I haven't tested that and so the PR needs a 2nd test. I can't test right now because I'm at work.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34817.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34817.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-21 13:48:45 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks!
thx
If accepted there are a lot of other places where we should change to logical css properties