[#34815] - [4.0] Badge icon
- Fixed in Code Base
- 20 Jul 2021
- Medium
- Build: 4.0-dev
- # 34815
- Diff
- brianteeman:allowed
User tests: Successful: Unsuccessful:
This pr adds spacing between the icon and the text. as far as I can see this is only used in one place as shown below
Before
After
This is a css change
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
Tested LTR and RTL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34815.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
NPM Resource Changed
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34815.
Under Privacy Dashboard, the icon is further apart from the text.
Under Privacy Dashboard, the icon is further apart from the text.
@Quy Without this PR it looks like this:
In both cases the distance between the icon and its text seems to be the same for both kinds of icons, but the icons have a different width and so it looks not well aligned in both cases.
So it seems the issue is not caused by this PR, it just becomes a bit more visible.
I think a fa-fw class in the markup could fix that.
@brianteeman Do you want to make a PR for that, too?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-20 19:46:54 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Merged - a little bit more space is better than no space. Thanks.
thanks
I have tested this item✅ successfully on 4927fa3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34815.