Feeling Lucky
Conflicting Files
?
[#34809] - [4.0] Clean up Category models
- Closed
- 29 Dec 2022
- Medium
- Build: 4.0-dev
- # 34809
- Diff
- joomdonation:clean_up_category_models
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PRs made several clean up to Category model class in our components:
- Remove un-used class properties (maybe it was used in the past, or even it is there by copy/paste during development)
- Added missing _leftsibling and _rightsibling class properties
- Remove unnessary bracket (). We are having more than needed in some line of code.
- Simpy the code to get active menu item from:
$app = Factory::getApplication();
$menu = $app->getMenu();
$active = $menu->getActive();To single line of code:
$active = Factory::getApplication()->getMenu()->getActive();Testing Instructions
Code review should be enough. If you have good IDE like phpstorm, it will clearly show you that the removed class properties are un-used.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_newsfeeds |
| Labels |
Added:
?
|
||
joomdonation
- comment
- 29 Dec 2022
Close due to conflicts. Will redo the PR at a later time
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-29 15:11:20 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
Conflicting Files
?
Removed: ? |
||
This pull request has automatically rebased to 4.2-dev.