? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
16 Jul 2021

Summary of Changes

Make sure we dont use the short array syntax within Joomla 3.x

Testing Instructions

Make sure you can install extensions from URL in php 5.3

Actual result BEFORE applying this Pull Request

Parse error: syntax error, unexpected '[' in administrator\components\com_installer\models\install.php on line 391

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 16 Jul 2021
avatar zero-24 zero-24 - change - 16 Jul 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2021
Category Administration com_installer
avatar alikon alikon - test_item - 16 Jul 2021 - Tested successfully
avatar alikon
alikon - comment - 16 Jul 2021

I have tested this item successfully on c3390b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

avatar richard67 richard67 - test_item - 16 Jul 2021 - Tested successfully
avatar richard67
richard67 - comment - 16 Jul 2021

I have tested this item successfully on c3390b9

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

avatar richard67 richard67 - change - 16 Jul 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 16 Jul 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34802.

avatar zero-24
zero-24 - comment - 18 Jul 2021

Merging for now thanks!

avatar zero-24 zero-24 - change - 18 Jul 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-07-18 06:38:43
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 18 Jul 2021
avatar zero-24 zero-24 - merge - 18 Jul 2021
avatar sakiss
sakiss - comment - 19 Jul 2021

Btw. Is this some type of code style requirement?

avatar alikon
alikon - comment - 19 Jul 2021

no j3 minimum requirement for php is 5.3 where short array syntax is illegal

Add a Comment

Login with GitHub to post a comment